Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2836943003: [turbofan] Consolidate compatible element loads. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Consolidate compatible element loads. This changes behavior of TurboFan to match the behavior of Crankshaft when it comes to polymorphic loads of similar elements kind (i.e. all tagged or all double), where we should use the "worst case" code without a transition. This is often much faster than transitioning the elements to the worst case first, trading a TransitionElementsKind for a CheckMaps and avoiding mutation of the array. This is beneficial for various crypto benchmarks, which don't need to pay the cost for TransitionElementsKind now. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2836943003 Cr-Commit-Position: refs/heads/master@{#44815} Committed: https://chromium.googlesource.com/v8/v8/+/d853b2382e035ef6e4b38ebbc8de827570d076b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M src/compiler/access-info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/access-info.cc View 2 chunks +56 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-24 18:48:42 UTC) #1
Jarin
lgtm. Could you say here where and by how much it actually helps?
3 years, 8 months ago (2017-04-24 19:06:18 UTC) #4
Benedikt Meurer
I see 2-3% on the SunSpider/crypto line items and 5% on the Octane/crypto one locally. ...
3 years, 8 months ago (2017-04-24 19:07:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836943003/1
3 years, 8 months ago (2017-04-24 19:37:30 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 19:40:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d853b2382e035ef6e4b38ebbc8de827570d...

Powered by Google App Engine
This is Rietveld 408576698