Remove CommitPendingSelection() from LayoutView::HitTestNoLifecycleUpdate()

Remove CommitPendingSelection() from LayoutView::HitTestNoLifecycleUpdate()

That's because marking LayoutObject::SelectionState doesn't affect hit test.

BUG=708453
Review-Url: https://codereview.chromium.org/2836843002
Cr-Commit-Position: refs/heads/master@{#466908}
Committed: https://chromium.googlesource.com/chromium/src/+/fb75c0c4e9721fcbca5f6229cf2e5dab5e8d9fcd

[yoichio, 2017-04-24 04:59:06]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 04:59:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 07:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 07:32:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoichio, 2017-04-24 09:08:01]

Description was changed from

==========
Remove CommitPendingSelection() from  LayoutView::HitTestNoLifecycleUpdate()

BUG=708453
==========

to

==========
Remove CommitPendingSelection() from LayoutView::HitTestNoLifecycleUpdate()

That's because marking LayoutObject::SelectionState doesn't affect hit test.

BUG=708453
==========

[yoichio, 2017-04-24 09:08:01]

yoichio@chromium.org changed reviewers:
+ kojii@chromium.org, yosin@chromium.org

[kojii, 2017-04-25 02:23:48]

lgtm, probably done for some tests to pass but great to learn it's no longer
needed.

[yoichio, 2017-04-25 04:03:49]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-04-25 04:04:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-04-25 07:01:21]

On 2017/04/25 at 02:23:48, kojii wrote:
> lgtm, probably done for some tests to pass but great to learn it's no longer
needed.

lgtm


There are two call sites of |LayoutView::HitTestNoLifecycleUpdate()|
1. LayoutView::HitTest() which calls
UpdateLifecycleToCompositingCleanPlusScrolling() == CommitPendingSelection() is
called.
2. LayoutPart::NodeAtPoint(); many call sites. Not sure CommitPendingSelection()
is called.

It seems selection state doesn't affect hit test result. We don't need to
SelectionState in LayoutObject.

[commit-bot: I haz the power, 2017-04-25 07:01:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493093029928850, "parent_rev":
"fbecc55ae2f4923fd2731391e33af6c37ff7ee2a", "commit_rev":
"fb75c0c4e9721fcbca5f6229cf2e5dab5e8d9fcd"}

[commit-bot: I haz the power, 2017-04-25 07:01:41]

Description was changed from

==========
Remove CommitPendingSelection() from LayoutView::HitTestNoLifecycleUpdate()

That's because marking LayoutObject::SelectionState doesn't affect hit test.

BUG=708453
==========

to

==========
Remove CommitPendingSelection() from LayoutView::HitTestNoLifecycleUpdate()

That's because marking LayoutObject::SelectionState doesn't affect hit test.

BUG=708453

Review-Url: https://codereview.chromium.org/2836843002
Cr-Commit-Position: refs/heads/master@{#466908}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb75c0c4e9721fcbca5f6229cf2e...
==========

[commit-bot: I haz the power, 2017-04-25 07:01:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb75c0c4e9721fcbca5f6229cf2e...