Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2836843002: Remove CommitPendingSelection() from LayoutView::HitTestNoLifecycleUpdate() (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 return HitTestNoLifecycleUpdate(result); 121 return HitTestNoLifecycleUpdate(result);
122 } 122 }
123 123
124 bool LayoutView::HitTestNoLifecycleUpdate(HitTestResult& result) { 124 bool LayoutView::HitTestNoLifecycleUpdate(HitTestResult& result) {
125 TRACE_EVENT_BEGIN0("blink,devtools.timeline", "HitTest"); 125 TRACE_EVENT_BEGIN0("blink,devtools.timeline", "HitTest");
126 hit_test_count_++; 126 hit_test_count_++;
127 127
128 DCHECK(!result.GetHitTestLocation().IsRectBasedTest() || 128 DCHECK(!result.GetHitTestLocation().IsRectBasedTest() ||
129 result.GetHitTestRequest().ListBased()); 129 result.GetHitTestRequest().ListBased());
130 130
131 CommitPendingSelection();
132
133 uint64_t dom_tree_version = GetDocument().DomTreeVersion(); 131 uint64_t dom_tree_version = GetDocument().DomTreeVersion();
134 HitTestResult cache_result = result; 132 HitTestResult cache_result = result;
135 bool hit_layer = false; 133 bool hit_layer = false;
136 if (hit_test_cache_->LookupCachedResult(cache_result, dom_tree_version)) { 134 if (hit_test_cache_->LookupCachedResult(cache_result, dom_tree_version)) {
137 hit_test_cache_hits_++; 135 hit_test_cache_hits_++;
138 hit_layer = true; 136 hit_layer = true;
139 result = cache_result; 137 result = cache_result;
140 } else { 138 } else {
141 hit_layer = Layer()->HitTest(result); 139 hit_layer = Layer()->HitTest(result);
142 140
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
813 // Frame scroll corner is painted using LayoutView as the display item client. 811 // Frame scroll corner is painted using LayoutView as the display item client.
814 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() && 812 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() &&
815 (GetFrameView()->HorizontalScrollbar() || 813 (GetFrameView()->HorizontalScrollbar() ||
816 GetFrameView()->VerticalScrollbar())) 814 GetFrameView()->VerticalScrollbar()))
817 return false; 815 return false;
818 816
819 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize(); 817 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize();
820 } 818 }
821 819
822 } // namespace blink 820 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698