Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2836813006: Revert of Eliminate ChildThread InterfaceRegistry. (Closed)

Created:
3 years, 8 months ago by pkalinnikov
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Eliminate ChildThread InterfaceRegistry. (patchset #8 id:140001 of https://codereview.chromium.org/2820883002/ ) Reason for revert: Looks like it might be causing ContentBrowserTest.BrowserCrashCallStack time-out on "Linux ChromiumOS Tests (dbg)" bot (also "Linux Tests (dbg)") consistently. Original issue's description: > Eliminate ChildThread InterfaceRegistry. > > Eliminate ChildThread InterfaceRegistry. Also cleans up ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface(). > > R=rockot@chromium.org > > Review-Url: https://codereview.chromium.org/2820883002 > Cr-Commit-Position: refs/heads/master@{#466851} > Committed: https://chromium.googlesource.com/chromium/src/+/92072b3d9f87ffe78a4e977dd85db597452caa92 TBR=rockot@chromium.org,ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2836813006 Cr-Commit-Position: refs/heads/master@{#466948} Committed: https://chromium.googlesource.com/chromium/src/+/2aa1a170c5f8709ce1e1fde42cf49c76d4e24a9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -15 lines) Patch
M content/child/child_thread_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/service_manager/service_manager_connection_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/service_manager/service_manager_connection_impl.cc View 8 chunks +78 lines, -14 lines 0 comments Download
M content/public/child/child_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/common/service_manager_connection.h View 2 chunks +19 lines, -0 lines 0 comments Download
M content/public/test/mock_render_thread.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pkalinnikov
Created Revert of Eliminate ChildThread InterfaceRegistry.
3 years, 8 months ago (2017-04-25 12:05:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836813006/1
3 years, 8 months ago (2017-04-25 12:05:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2aa1a170c5f8709ce1e1fde42cf49c76d4e24a9c
3 years, 8 months ago (2017-04-25 12:06:12 UTC) #6
pkalinnikov
3 years, 8 months ago (2017-04-25 14:15:41 UTC) #7
Message was sent while issue was closed.
FIY: This revert helped to make the bots happy.

Powered by Google App Engine
This is Rietveld 408576698