Eliminate ChildThread InterfaceRegistry.

Eliminate ChildThread InterfaceRegistry.

Eliminate ChildThread InterfaceRegistry. Also cleans up ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface().

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2820883002
Cr-Original-Commit-Position: refs/heads/master@{#466851}
Committed: https://chromium.googlesource.com/chromium/src/+/92072b3d9f87ffe78a4e977dd85db597452caa92
Review-Url: https://codereview.chromium.org/2820883002
Cr-Commit-Position: refs/heads/master@{#467112}
Committed: https://chromium.googlesource.com/chromium/src/+/6f95c47544ffb481b315c6d50b5e89d5a9dcecff

[Ben Goodger (Google), 2017-04-16 14:33:58]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 14:34:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 14:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 14:37:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2017-04-16 14:49:04]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 14:49:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 15:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 15:26:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2017-04-16 20:51:27]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 20:51:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 23:20:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 23:20:29]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2017-04-20 17:20:07]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 17:20:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-20 18:29:28]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2017-04-20 18:30:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 18:30:14]

This CL has an open dependency (Issue 2819903004 Patch 360001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Ben Goodger (Google), 2017-04-24 22:20:31]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 22:21:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-04-24 22:36:31]

https://codereview.chromium.org/2820883002/diff/120001/content/common/service...
File content/common/service_manager/service_manager_connection_impl.cc (right):

https://codereview.chromium.org/2820883002/diff/120001/content/common/service...
content/common/service_manager/service_manager_connection_impl.cc:330:
service_manager::ServiceInfo last_source_info_;
This member variable doesn't seem to be necessary?

https://codereview.chromium.org/2820883002/diff/120001/content/common/service...
File content/common/service_manager/service_manager_connection_impl.h (left):

https://codereview.chromium.org/2820883002/diff/120001/content/common/service...
content/common/service_manager/service_manager_connection_impl.h:43: void
SetupInterfaceRequestProxies(
\o/

[Ben Goodger (Google), 2017-04-24 23:41:21]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 23:41:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-04-24 23:42:23]

Updated PTAL

[Ken Rockot(use gerrit already), 2017-04-24 23:43:06]

lgtm

[commit-bot: I haz the power, 2017-04-25 00:46:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 00:46:25]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2017-04-25 01:05:32]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2017-04-25 01:05:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 01:11:55]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493082332841760,
"parent_rev": "e8adf9ff14109d9a207c8abd143ca508085702b1", "commit_rev":
"92072b3d9f87ffe78a4e977dd85db597452caa92"}

[commit-bot: I haz the power, 2017-04-25 01:12:26]

Description was changed from

==========
Eliminate ChildThread InterfaceRegistry.

Eliminate ChildThread InterfaceRegistry. Also cleans up
ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface().

R=rockot@chromium.org
==========

to

==========
Eliminate ChildThread InterfaceRegistry.

Eliminate ChildThread InterfaceRegistry. Also cleans up
ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface().

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2820883002
Cr-Commit-Position: refs/heads/master@{#466851}
Committed:
https://chromium.googlesource.com/chromium/src/+/92072b3d9f87ffe78a4e977dd85d...
==========

[commit-bot: I haz the power, 2017-04-25 01:12:27]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/92072b3d9f87ffe78a4e977dd85d...

[findit-for-me, 2017-04-25 03:40:57]

Findit(https://goo.gl/kROfz5) identified this CL at revision 466851 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[pkalinnikov, 2017-04-25 12:05:13]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2836813006/ by pkalinnikov@chromium.org.

The reason for reverting is: Looks like it might be causing
ContentBrowserTest.BrowserCrashCallStack time-out on "Linux ChromiumOS Tests
(dbg)" bot (also "Linux Tests (dbg)") consistently..

[Ben Goodger (Google), 2017-04-25 15:47:14]

Description was changed from

==========
Eliminate ChildThread InterfaceRegistry.

Eliminate ChildThread InterfaceRegistry. Also cleans up
ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface().

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2820883002
Cr-Commit-Position: refs/heads/master@{#466851}
Committed:
https://chromium.googlesource.com/chromium/src/+/92072b3d9f87ffe78a4e977dd85d...
==========

to

==========
Eliminate ChildThread InterfaceRegistry.

Eliminate ChildThread InterfaceRegistry. Also cleans up
ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface().

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2820883002
Cr-Commit-Position: refs/heads/master@{#466851}
Committed:
https://chromium.googlesource.com/chromium/src/+/92072b3d9f87ffe78a4e977dd85d...
==========

[Ben Goodger (Google), 2017-04-25 19:59:48]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-04-25 19:59:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2820883002/#ps160001
(title: ".")

[commit-bot: I haz the power, 2017-04-25 20:00:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 21:08:57]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493150388575550,
"parent_rev": "23d381fd827c8880b85fe5794627e98af07454cc", "commit_rev":
"6f95c47544ffb481b315c6d50b5e89d5a9dcecff"}

[commit-bot: I haz the power, 2017-04-25 21:09:05]

Description was changed from

==========
Eliminate ChildThread InterfaceRegistry.

Eliminate ChildThread InterfaceRegistry. Also cleans up
ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface().

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2820883002
Cr-Commit-Position: refs/heads/master@{#466851}
Committed:
https://chromium.googlesource.com/chromium/src/+/92072b3d9f87ffe78a4e977dd85d...
==========

to

==========
Eliminate ChildThread InterfaceRegistry.

Eliminate ChildThread InterfaceRegistry. Also cleans up
ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface().

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2820883002
Cr-Original-Commit-Position: refs/heads/master@{#466851}
Committed:
https://chromium.googlesource.com/chromium/src/+/92072b3d9f87ffe78a4e977dd85d...
Review-Url: https://codereview.chromium.org/2820883002
Cr-Commit-Position: refs/heads/master@{#467112}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f95c47544ffb481b315c6d50b5e...
==========

[commit-bot: I haz the power, 2017-04-25 21:09:06]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/6f95c47544ffb481b315c6d50b5e...