Better overflow handling for aspect-ratio MQ.

Better overflow handling for aspect-ratio MQ.

This change fixes two issues:

1. Clamp instead of casting double values from parser to internal
   unsigned storage.
2. Promote width/height/numerator/denominator multiplications to double
   to avoid integer overflow for large numerator/denominators.

R=yoav@yoav.ws,suzyh@chromium.org
BUG=676709, 714079
Review-Url: https://codereview.chromium.org/2836613002
Cr-Commit-Position: refs/heads/master@{#467615}
Committed: https://chromium.googlesource.com/chromium/src/+/cf115265d17e7eec4e8c6c2d4441942988dc84db

[rune, 2017-04-21 11:08:12]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 11:08:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-04-21 11:09:49]

ptal

I wrote the layout test first, but I guess the unit test may suffice. I can
remove the layout test if you want.

[commit-bot: I haz the power, 2017-04-21 12:56:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 12:56:58]

Dry run: This issue passed the CQ dry run.

[rune, 2017-04-25 06:33:59]

rune@opera.com changed reviewers:
+ meade@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-04-26 00:08:13]

Thanks for doing this, Rune, and apologies for the delay. This lgtm but as I
said I'm not confident in my understanding of this code so I recommend
additional reviewers.

[rune, 2017-04-26 07:09:35]

On 2017/04/26 00:08:13, suzyh_UTC10 wrote:
> Thanks for doing this, Rune, and apologies for the delay. This lgtm but as I
> said I'm not confident in my understanding of this code so I recommend
> additional reviewers.

yoav@, meade@ ?

[meade_UTC10, 2017-04-27 03:15:19]

lgtm

[rune, 2017-04-27 05:29:21]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-04-27 05:29:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 07:13:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493270961168510, "parent_rev":
"440629589dbc6ed4fb54dbcc616bca0c06d88632", "commit_rev":
"cf115265d17e7eec4e8c6c2d4441942988dc84db"}

[commit-bot: I haz the power, 2017-04-27 07:14:02]

Description was changed from

==========
Better overflow handling for aspect-ratio MQ.

This change fixes two issues:

1. Clamp instead of casting double values from parser to internal
   unsigned storage.
2. Promote width/height/numerator/denominator multiplications to double
   to avoid integer overflow for large numerator/denominators.

R=yoav@yoav.ws,suzyh@chromium.org
BUG=676709,714079
==========

to

==========
Better overflow handling for aspect-ratio MQ.

This change fixes two issues:

1. Clamp instead of casting double values from parser to internal
   unsigned storage.
2. Promote width/height/numerator/denominator multiplications to double
   to avoid integer overflow for large numerator/denominators.

R=yoav@yoav.ws,suzyh@chromium.org
BUG=676709,714079

Review-Url: https://codereview.chromium.org/2836613002
Cr-Commit-Position: refs/heads/master@{#467615}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf115265d17e7eec4e8c6c2d4441...
==========

[commit-bot: I haz the power, 2017-04-27 07:14:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf115265d17e7eec4e8c6c2d4441...