third_party/WebKit/Source/core/css/MediaQueryExp.cpp - Issue 2836613002: Better overflow handling for aspect-ratio MQ.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryExp.cpp

Issue 2836613002: Better overflow handling for aspect-ratio MQ. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/MediaQueryExp.cpp

diff --git a/third_party/WebKit/Source/core/css/MediaQueryExp.cpp b/third_party/WebKit/Source/core/css/MediaQueryExp.cpp

index b97736c12ce4037289bb57605c11e3bc8ced42c2..a43c9830e2284d9ad2882deed98be6758081e660 100644

--- a/third_party/WebKit/Source/core/css/MediaQueryExp.cpp

+++ b/third_party/WebKit/Source/core/css/MediaQueryExp.cpp

@@ -284,8 +284,8 @@ MediaQueryExp* MediaQueryExp::CreateIfValid(

denominator.GetNumericValueType() != kIntegerValueType)

return nullptr;

- exp_value.numerator = (unsigned)numerator.NumericValue();

- exp_value.denominator = (unsigned)denominator.NumericValue();

+ exp_value.numerator = clampTo<unsigned>(numerator.NumericValue());

+ exp_value.denominator = clampTo<unsigned>(denominator.NumericValue());

exp_value.is_ratio = true;

} else {

return nullptr;

« no previous file with comments | « third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp ('k') | no next file » | no next file with comments »