Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2836523002: Disable Clear Browsing Data menu item in guest profiles (Closed)

Created:
3 years, 8 months ago by tsergeant
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Disable Clear Browsing Data menu item in guest profiles Following the switch to MD Settings, the Clear Browsing Data dialog is not accessible from guest profiles -- instead, closing the session is the primary way to delete the guest's data. This CL disables the entry point to Clear Browsing Data from the main menu, which otherwise would open MD Settings with no CBD dialog visible. BUG=694394 Review-Url: https://codereview.chromium.org/2823983003 Cr-Commit-Position: refs/heads/master@{#465131} (cherry picked from commit 341a827fdc6dcfc2dca619121cf18117c72225f2) Review-Url: https://codereview.chromium.org/2836523002 . Cr-Commit-Position: refs/branch-heads/3071@{#110} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/e182fef5af8b9168b97f25bb98ea03c61e9cf8e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tsergeant
3 years, 8 months ago (2017-04-21 01:14:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e182fef5af8b9168b97f25bb98ea03c61e9cf8e0.

Powered by Google App Engine
This is Rietveld 408576698