Disable Clear Browsing Data menu item in guest profiles

Disable Clear Browsing Data menu item in guest profiles

Following the switch to MD Settings, the Clear Browsing Data dialog is
not accessible from guest profiles -- instead, closing the session is
the primary way to delete the guest's data.

This CL disables the entry point to Clear Browsing Data from the main
menu, which otherwise would open MD Settings with no CBD dialog visible.

BUG=694394
Review-Url: https://codereview.chromium.org/2823983003
Cr-Commit-Position: refs/heads/master@{#465131}
Committed: https://chromium.googlesource.com/chromium/src/+/341a827fdc6dcfc2dca619121cf18117c72225f2

[tsergeant, 2017-04-18 01:25:17]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 01:25:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-04-18 01:26:12]

tsergeant@chromium.org changed reviewers:
+ pkasting@chromium.org

[tsergeant, 2017-04-18 01:26:13]

pkasting@, please take a look!

This is a little change we'd like to fix for M59.

[Peter Kasting, 2017-04-18 01:58:13]

LGTM

https://codereview.chromium.org/2823983003/diff/1/chrome/browser/ui/browser_c...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/2823983003/diff/1/chrome/browser/ui/browser_c...
chrome/browser/ui/browser_command_controller.cc:802: normal_window &&
!guest_session);
Seems like maybe the old |normal_window| check was wrong?  I'd think we just
want to check !guest_session here, as in the "show history" case above.

[commit-bot: I haz the power, 2017-04-18 02:07:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 02:07:40]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-04-18 03:10:36]

Thanks for reviewing!

https://codereview.chromium.org/2823983003/diff/1/chrome/browser/ui/browser_c...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/2823983003/diff/1/chrome/browser/ui/browser_c...
chrome/browser/ui/browser_command_controller.cc:802: normal_window &&
!guest_session);
On 2017/04/18 01:58:13, Peter Kasting wrote:
> Seems like maybe the old |normal_window| check was wrong?  I'd think we just
> want to check !guest_session here, as in the "show history" case above.

Yup, this makes sense: just checking !guest_session makes it possible to
Ctrl-Shift-Del to open CBD from a popup or app window, the same as how you can
Ctrl-H to open History.

Done.

[tsergeant, 2017-04-18 03:13:29]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-04-18 03:13:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2823983003/#ps20001
(title: "Enable in popup windows")

[commit-bot: I haz the power, 2017-04-18 03:13:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 03:54:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492485209132710,
"parent_rev": "7c3a5b71c7bf345605af3c613d9c1bed7d4f84f5", "commit_rev":
"341a827fdc6dcfc2dca619121cf18117c72225f2"}

[commit-bot: I haz the power, 2017-04-18 03:55:05]

Description was changed from

==========
Disable Clear Browsing Data menu item in guest profiles

Following the switch to MD Settings, the Clear Browsing Data dialog is
not accessible from guest profiles -- instead, closing the session is
the primary way to delete the guest's data.

This CL disables the entry point to Clear Browsing Data from the main
menu, which otherwise would open MD Settings with no CBD dialog visible.

BUG=694394
==========

to

==========
Disable Clear Browsing Data menu item in guest profiles

Following the switch to MD Settings, the Clear Browsing Data dialog is
not accessible from guest profiles -- instead, closing the session is
the primary way to delete the guest's data.

This CL disables the entry point to Clear Browsing Data from the main
menu, which otherwise would open MD Settings with no CBD dialog visible.

BUG=694394

Review-Url: https://codereview.chromium.org/2823983003
Cr-Commit-Position: refs/heads/master@{#465131}
Committed:
https://chromium.googlesource.com/chromium/src/+/341a827fdc6dcfc2dca619121cf1...
==========

[commit-bot: I haz the power, 2017-04-18 03:55:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/341a827fdc6dcfc2dca619121cf1...