Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2836393002: Remove DocumentMarker::SpellCheckClientMarkers() (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine, Xiaocheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DocumentMarker::SpellCheckClientMarkers() This is redundant with DocumentMarker::MisspellingMarkers(). Two arguments for keeping the MisspellingMarkers() name instead of this one: - "MisspellingMarkers" is shorter than "SpellCheckClientMarkers" - MisspellingMarkers() has nine callsites, SpellCheckClientMarkers() only has one BUG=707867 Review-Url: https://codereview.chromium.org/2836393002 Cr-Commit-Position: refs/heads/master@{#467226} Committed: https://chromium.googlesource.com/chromium/src/+/a487ccbcee73cf847f61aaf0c35b09447dfa3d73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarker.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
rlanday
3 years, 8 months ago (2017-04-26 01:20:31 UTC) #6
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-26 03:42:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836393002/1
3 years, 8 months ago (2017-04-26 03:43:20 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 03:58:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a487ccbcee73cf847f61aaf0c35b...

Powered by Google App Engine
This is Rietveld 408576698