Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Side by Side Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

Issue 2836393002: Remove DocumentMarker::SpellCheckClientMarkers() (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 255
256 void SpellCheckRequester::DidCheckSucceed( 256 void SpellCheckRequester::DidCheckSucceed(
257 int sequence, 257 int sequence,
258 const Vector<TextCheckingResult>& results) { 258 const Vector<TextCheckingResult>& results) {
259 // TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets 259 // TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
260 // needs to be audited. See http://crbug.com/590369 for more details. 260 // needs to be audited. See http://crbug.com/590369 for more details.
261 GetFrame().GetDocument()->UpdateStyleAndLayoutIgnorePendingStylesheets(); 261 GetFrame().GetDocument()->UpdateStyleAndLayoutIgnorePendingStylesheets();
262 262
263 TextCheckingRequestData request_data = processing_request_->Data(); 263 TextCheckingRequestData request_data = processing_request_->Data();
264 if (request_data.Sequence() == sequence) { 264 if (request_data.Sequence() == sequence) {
265 DocumentMarker::MarkerTypes markers = 265 DocumentMarker::MarkerTypes markers = DocumentMarker::MisspellingMarkers();
266 DocumentMarker::SpellCheckClientMarkers();
267 if (processing_request_->IsValid()) { 266 if (processing_request_->IsValid()) {
268 Range* checking_range = processing_request_->CheckingRange(); 267 Range* checking_range = processing_request_->CheckingRange();
269 GetFrame().GetDocument()->Markers().RemoveMarkersInRange( 268 GetFrame().GetDocument()->Markers().RemoveMarkersInRange(
270 EphemeralRange(checking_range), markers); 269 EphemeralRange(checking_range), markers);
271 } 270 }
272 } 271 }
273 DidCheck(sequence, results); 272 DidCheck(sequence, results);
274 } 273 }
275 274
276 void SpellCheckRequester::DidCheckCancel(int sequence) { 275 void SpellCheckRequester::DidCheckCancel(int sequence) {
277 Vector<TextCheckingResult> results; 276 Vector<TextCheckingResult> results;
278 DidCheck(sequence, results); 277 DidCheck(sequence, results);
279 } 278 }
280 279
281 DEFINE_TRACE(SpellCheckRequester) { 280 DEFINE_TRACE(SpellCheckRequester) {
282 visitor->Trace(frame_); 281 visitor->Trace(frame_);
283 visitor->Trace(processing_request_); 282 visitor->Trace(processing_request_);
284 visitor->Trace(request_queue_); 283 visitor->Trace(request_queue_);
285 } 284 }
286 285
287 } // namespace blink 286 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698