Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2836333002: Revert of Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. (Closed)

Created:
3 years, 8 months ago by hcarmona
Modified:
3 years, 8 months ago
Reviewers:
Bernhard Bauer, fdoray
CC:
chromium-reviews, pam+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. (patchset #1 id:1 of https://codereview.chromium.org/2837943002/ ) Reason for revert: SupervisedUserURLFilterTest tests are failing. See: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37642 Original issue's description: > Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. > > The blocking pool is being deprecated in favor of TaskScheduler. > > BUG=667892 > R=bauerb@chromium.org > > Review-Url: https://codereview.chromium.org/2837943002 > Cr-Commit-Position: refs/heads/master@{#466982} > Committed: https://chromium.googlesource.com/chromium/src/+/47eaa2f4ade5724ed7bdbbd736579ae48702b9aa TBR=bauerb@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667892 Review-Url: https://codereview.chromium.org/2836333002 Cr-Commit-Position: refs/heads/master@{#467016} Committed: https://chromium.googlesource.com/chromium/src/+/c8aaea4fc06896f27d1d292ed16ed627b60d7fa2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 4 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hcarmona
Created Revert of Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc.
3 years, 8 months ago (2017-04-25 16:42:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836333002/1
3 years, 8 months ago (2017-04-25 16:43:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c8aaea4fc06896f27d1d292ed16ed627b60d7fa2
3 years, 8 months ago (2017-04-25 16:43:49 UTC) #6
Bernhard Bauer
3 years, 8 months ago (2017-04-25 16:57:56 UTC) #7
Message was sent while issue was closed.
Hm... it looks like the SupervisedUserURLFilter is a member of the test fixture,
so is it possible that it's constructed before the TaskScheduler has been
initialized? When does that usually happen?

Powered by Google App Engine
This is Rietveld 408576698