Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2837943002:
Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. (Closed)
|
Created:
3 years, 8 months ago by fdoray Modified:
3 years, 7 months ago Reviewers:
Bernhard Bauer CC:
chromium-reviews, pam+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[reland] Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc.
Relanding with a base::test::ScopedTaskEnvironment in
supervised_user_url_filter_unittest.cc.
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=bauerb@chromium.org
Review-Url: https://codereview.chromium.org/2837943002
Cr-Original-Commit-Position: refs/heads/master@{#466982}
Committed: https://chromium.googlesource.com/chromium/src/+/47eaa2f4ade5724ed7bdbbd736579ae48702b9aa
Review-Url: https://codereview.chromium.org/2837943002
Cr-Commit-Position: refs/heads/master@{#470098}
Committed: https://chromium.googlesource.com/chromium/src/+/ff7d4473b10d6afeeae908fed72cea38536e3480
Patch Set 1 #Patch Set 2 : add-ScopedTaskEnvironment #
Messages
Total messages: 26 (14 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority())? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior())? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bauerb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493129967720600, "parent_rev":
"0aa670e72d263ae9144a4a76feb09889e94c1ce6", "commit_rev":
"47eaa2f4ade5724ed7bdbbd736579ae48702b9aa"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2837943002 Cr-Commit-Position: refs/heads/master@{#466982} Committed: https://chromium.googlesource.com/chromium/src/+/47eaa2f4ade5724ed7bdbbd73657... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/47eaa2f4ade5724ed7bdbbd73657...
Message was sent while issue was closed.
Findit(https://goo.gl/kROfz5) identified this CL at revision 466982 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2836333002/ by hcarmona@chromium.org. The reason for reverting is: SupervisedUserURLFilterTest tests are failing. See: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C....
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2836373002/ by timav@chromium.org. The reason for reverting is: Android Tests (dbg) failing, http://crbug.com/715187.
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2837943002 Cr-Commit-Position: refs/heads/master@{#466982} Committed: https://chromium.googlesource.com/chromium/src/+/47eaa2f4ade5724ed7bdbbd73657... ========== to ========== [reland] Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. Relanding with a base::test::ScopedTaskEnvironment in supervised_user_url_filter_unittest.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2837943002 Cr-Commit-Position: refs/heads/master@{#466982} Committed: https://chromium.googlesource.com/chromium/src/+/47eaa2f4ade5724ed7bdbbd73657... ==========
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org Link to the patchset: https://codereview.chromium.org/2837943002/#ps20001 (title: "add-ScopedTaskEnvironment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494270783962840,
"parent_rev": "c15bda3bf4bbe231186176da9d809fed356f8cbf", "commit_rev":
"ff7d4473b10d6afeeae908fed72cea38536e3480"}
Message was sent while issue was closed.
Description was changed from ========== [reland] Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. Relanding with a base::test::ScopedTaskEnvironment in supervised_user_url_filter_unittest.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2837943002 Cr-Commit-Position: refs/heads/master@{#466982} Committed: https://chromium.googlesource.com/chromium/src/+/47eaa2f4ade5724ed7bdbbd73657... ========== to ========== [reland] Use TaskScheduler instead of blocking pool in supervised_user_url_filter.cc. Relanding with a base::test::ScopedTaskEnvironment in supervised_user_url_filter_unittest.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2837943002 Cr-Original-Commit-Position: refs/heads/master@{#466982} Committed: https://chromium.googlesource.com/chromium/src/+/47eaa2f4ade5724ed7bdbbd73657... Review-Url: https://codereview.chromium.org/2837943002 Cr-Commit-Position: refs/heads/master@{#470098} Committed: https://chromium.googlesource.com/chromium/src/+/ff7d4473b10d6afeeae908fed72c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ff7d4473b10d6afeeae908fed72c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
