Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2836303002: Revert of Roll WPR to the lastest commit (Closed)

Created:
3 years, 8 months ago by nednguyen
Modified:
3 years, 8 months ago
Reviewers:
Ryan Sleevi, mattm
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Roll WPR to the lastest commit (patchset #2 id:20001 of https://codereview.chromium.org/2841533003/ ) Reason for revert: Still causing certificate problem on Nexus bots :-( https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%282%29/builds/5499 Screen shot from the log: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_10-2017-04-25_00-51-2757619.png Original issue's description: > Roll WPR to the lastest commit > > List of changes: > > git log 6cffdf1fb6c9a6..66731e9ae8d3b3f7229 --date=short --no-merges --format='%ad %ae %s' > 2017-04-24 NghiaNguyenBH@gmail.com Update WPR documentation > 2017-04-17 rsleevi@chromium.org Whitespace > 2017-04-17 rsleevi@chromium.org Add unit test > 2017-04-17 rsleevi@chromium.org Explicitly set the version to X.509v3 > 2017-04-12 rsleevi@chromium.org Always include a subjectAltName and extendedKeyUsage extension in certs > > BUG=chromium:702194, chromium:711634 > TBR=ashleymarie@chromium.org,martiniss@chromium.org > > Review-Url: https://codereview.chromium.org/2841533003 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/892a0b6a45cc8b052638587744cc7a1b54efe2d4 TBR=rsleevi@chromium.org,mattm@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:702194, chromium:711634 Review-Url: https://codereview.chromium.org/2836303002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bc8989ef1a06a456807e406fcb1a6d337b270845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M telemetry/third_party/web-page-replay/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/third_party/web-page-replay/certutils.py View 2 chunks +10 lines, -5 lines 0 comments Download
M telemetry/third_party/web-page-replay/certutils_test.py View 1 chunk +1 line, -7 lines 0 comments Download
M telemetry/third_party/web-page-replay/documentation/GettingStarted.md View 1 chunk +37 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Revert of Roll WPR to the lastest commit
3 years, 8 months ago (2017-04-25 14:12:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836303002/1
3 years, 8 months ago (2017-04-25 14:12:39 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 14:12:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698