Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2841533003: Roll WPR to the lastest commit (Closed)

Created:
3 years, 8 months ago by nednguyen
Modified:
3 years, 8 months ago
Reviewers:
Ryan Sleevi, mattm
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Roll WPR to the lastest commit List of changes: git log 6cffdf1fb6c9a6..66731e9ae8d3b3f7229 --date=short --no-merges --format='%ad %ae %s' 2017-04-24 NghiaNguyenBH@gmail.com Update WPR documentation 2017-04-17 rsleevi@chromium.org Whitespace 2017-04-17 rsleevi@chromium.org Add unit test 2017-04-17 rsleevi@chromium.org Explicitly set the version to X.509v3 2017-04-12 rsleevi@chromium.org Always include a subjectAltName and extendedKeyUsage extension in certs BUG=chromium:702194, chromium:711634 TBR=ashleymarie@chromium.org,martiniss@chromium.org Review-Url: https://codereview.chromium.org/2841533003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/892a0b6a45cc8b052638587744cc7a1b54efe2d4

Patch Set 1 #

Total comments: 1

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -49 lines) Patch
M telemetry/third_party/web-page-replay/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M telemetry/third_party/web-page-replay/certutils.py View 2 chunks +5 lines, -10 lines 0 comments Download
M telemetry/third_party/web-page-replay/certutils_test.py View 1 chunk +7 lines, -1 line 0 comments Download
M telemetry/third_party/web-page-replay/documentation/GettingStarted.md View 1 1 chunk +5 lines, -37 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
nednguyen
I still need to run a try bot run on this on Android bots
3 years, 8 months ago (2017-04-24 14:32:55 UTC) #3
nednguyen
On 2017/04/24 14:32:55, nednguyen wrote: > I still need to run a try bot run ...
3 years, 8 months ago (2017-04-24 14:36:34 UTC) #4
mattm
lgtm https://codereview.chromium.org/2841533003/diff/1/telemetry/third_party/web-page-replay/README.md File telemetry/third_party/web-page-replay/README.md (right): https://codereview.chromium.org/2841533003/diff/1/telemetry/third_party/web-page-replay/README.md#newcode28 telemetry/third_party/web-page-replay/README.md:28: guidelines](documentation/Contributing.md). nit: extra whitespace snuck in here?
3 years, 8 months ago (2017-04-24 21:58:54 UTC) #5
nednguyen
On 2017/04/24 21:58:54, mattm wrote: > lgtm > > https://codereview.chromium.org/2841533003/diff/1/telemetry/third_party/web-page-replay/README.md > File telemetry/third_party/web-page-replay/README.md (right): > ...
3 years, 8 months ago (2017-04-24 22:40:47 UTC) #6
nednguyen
On 2017/04/24 22:40:47, nednguyen wrote: > On 2017/04/24 21:58:54, mattm wrote: > > lgtm > ...
3 years, 8 months ago (2017-04-24 22:54:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841533003/20001
3 years, 8 months ago (2017-04-24 22:55:09 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-24 22:55:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841533003/20001
3 years, 8 months ago (2017-04-24 22:56:48 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/892a0b6a45cc8b052638587744cc7a1b54efe2d4
3 years, 8 months ago (2017-04-24 23:20:36 UTC) #19
nednguyen
3 years, 8 months ago (2017-04-25 14:12:28 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2836303002/ by nednguyen@google.com.

The reason for reverting is: Still causing certificate problem on Nexus bots :-(

https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2...

Screen shot from the log:
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-outpu....

Powered by Google App Engine
This is Rietveld 408576698