Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1476)

Issue 2836283002: [blink] Fix crashes in CanvasRenderingContext2DTests. (Closed)

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[blink] Fix crashes in CanvasRenderingContext2DTests. ElementRequestsCompositingUpdateOnHibernateAndWakeUp caused crashes after finishing. It seems this is caused by resetting the testing platform after TearDown() runs. This patch makes sure that it is reset before. BUG=713352 Review-Url: https://codereview.chromium.org/2826403002 Cr-Commit-Position: refs/heads/master@{#466604} (cherry picked from commit d5521d9d44f51d4372ac4246747761c437739e9d) Review-Url: https://codereview.chromium.org/2836283002 . Cr-Commit-Position: refs/branch-heads/3071@{#199} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f67183d3d0bc00c432556d98ae989759dca2d7dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Eric Seckler
3 years, 8 months ago (2017-04-25 10:59:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f67183d3d0bc00c432556d98ae989759dca2d7dc.

Powered by Google App Engine
This is Rietveld 408576698