Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2826403002: [blink] Fix crashes in CanvasRenderingContext2DTests. (Closed)

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, blink-reviews, Rik, haraken, danakj, Ken Russell (switch to Gerrit)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[blink] Fix crashes in CanvasRenderingContext2DTests. ElementRequestsCompositingUpdateOnHibernateAndWakeUp caused crashes after finishing. It seems this is caused by resetting the testing platform after TearDown() runs. This patch makes sure that it is reset before. BUG=713352 Review-Url: https://codereview.chromium.org/2826403002 Cr-Commit-Position: refs/heads/master@{#466604} Committed: https://chromium.googlesource.com/chromium/src/+/d5521d9d44f51d4372ac4246747761c437739e9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eric Seckler
senorblanco@ / xlai@, could you have a look since junov@ is OOO? Thanks!
3 years, 8 months ago (2017-04-20 08:10:14 UTC) #2
Justin Novosad
lgtm
3 years, 8 months ago (2017-04-20 21:21:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826403002/1
3 years, 8 months ago (2017-04-24 07:38:46 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 09:11:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5521d9d44f51d4372ac42467477...

Powered by Google App Engine
This is Rietveld 408576698