Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2836273002: Don't call AnimateClearingOneNotification if clearing all is already started. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Don't call AnimateClearingOneNotification if clearing all is already started. AnimateClearingOneNotification calls itself recursively with delay until all notifications to be cleared are removed from the list. Calling AnimateClearingOneNotification by another reason while in the delay causes calling front() on the empty std::list. BUG=712162 Review-Url: https://codereview.chromium.org/2826003002 Cr-Commit-Position: refs/heads/master@{#465525} (cherry picked from commit 3408db33fff22d04e05f38c875258debb25967f5) Review-Url: https://codereview.chromium.org/2836273002 . Cr-Commit-Position: refs/branch-heads/3029@{#770} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7a492c8eed94ad223324dc033281f31b384bb200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/message_center/views/message_list_view.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
yhanada
3 years, 8 months ago (2017-04-25 04:59:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a492c8eed94ad223324dc033281f31b384bb200 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698