Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2826003002: Don't call AnimateClearingOneNotification if clearing all is already started. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
yoshiki, Eliot Courtney
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't call AnimateClearingOneNotification if clearing all is already started. AnimateClearingOneNotification calls itself recursively with delay until all notifications to be cleared are removed from the list. Calling AnimateClearingOneNotification by another reason while in the delay causes calling front() on the empty std::list. BUG=712162 Review-Url: https://codereview.chromium.org/2826003002 Cr-Commit-Position: refs/heads/master@{#465525} Committed: https://chromium.googlesource.com/chromium/src/+/3408db33fff22d04e05f38c875258debb25967f5

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/message_center/views/message_list_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
yhanada
PTAL.
3 years, 8 months ago (2017-04-19 07:11:27 UTC) #6
Eliot Courtney
lgtm
3 years, 8 months ago (2017-04-19 07:15:44 UTC) #8
yoshiki
lgtm Thanks!
3 years, 8 months ago (2017-04-19 07:54:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826003002/20001
3 years, 8 months ago (2017-04-19 07:56:24 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 08:01:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3408db33fff22d04e05f38c87525...

Powered by Google App Engine
This is Rietveld 408576698