Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2836253002: Make the Data Saver site breakdown "Remaining sites" expandable (Closed)

Created:
3 years, 7 months ago by megjablon
Modified:
3 years, 7 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the Data Saver site breakdown "Remaining sites" expandable The site breakdown expands by ten entries when "remaining sites" is clicked. BUG=714838 Review-Url: https://codereview.chromium.org/2836253002 Cr-Commit-Position: refs/heads/master@{#467212} Committed: https://chromium.googlesource.com/chromium/src/+/340fc2257b7a801b7d905e495756d4322054cb3f

Patch Set 1 #

Patch Set 2 : Expand site breakdown on click #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java View 1 3 chunks +12 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
megjablon
PTAL, thanks!
3 years, 7 months ago (2017-04-24 23:54:14 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-04-25 03:32:00 UTC) #3
megjablon
Changing what this cl does to handle the interactivity problem. The color needed to be ...
3 years, 7 months ago (2017-04-25 18:55:05 UTC) #7
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-04-26 00:29:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836253002/40001
3 years, 7 months ago (2017-04-26 01:18:34 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 02:48:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/340fc2257b7a801b7d905e495756...

Powered by Google App Engine
This is Rietveld 408576698