Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2829043003: Rename the Data Saver main menu flags (Closed)

Created:
3 years, 8 months ago by megjablon
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang, RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the Data Saver main menu flags The Data Saver main menu item moved to the footer and keeps the settings menu option. Update the flag and feature descriptions. BUG=702799 Review-Url: https://codereview.chromium.org/2829043003 Cr-Commit-Position: refs/heads/master@{#466195} Committed: https://chromium.googlesource.com/chromium/src/+/acb36d186d69f651d0e30e38e291da6652d54583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/flag_descriptions.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
megjablon
PTAL, thanks!
3 years, 8 months ago (2017-04-20 21:23:14 UTC) #2
Lei Zhang
lgtm
3 years, 8 months ago (2017-04-20 21:25:58 UTC) #3
RyanSturm
lgtm
3 years, 8 months ago (2017-04-20 21:28:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829043003/1
3 years, 8 months ago (2017-04-20 22:11:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/394389) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 8 months ago (2017-04-20 22:14:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829043003/1
3 years, 8 months ago (2017-04-20 23:29:11 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 00:10:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/acb36d186d69f651d0e30e38e291...

Powered by Google App Engine
This is Rietveld 408576698