RELAND: GeoLocation: add support for GmsCore location provider

RELAND: GeoLocation: add support for GmsCore location provider

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed. This CL adds a flag to enable
explicitly the GMScore provider, and uses it
from Chrome.


[1] https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src/android/webkit/cts/GeolocationTest.java


Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014
Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed: https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546a44f5603b99c

patch from issue 2809813002 at patchset 260001 (http://crrev.com/2809813002#ps260001)

TBR=  aelias@chromium.org, reillyg@chromium.org, agrieve@chromium.org who LGTM PS1

Review-Url: https://codereview.chromium.org/2836213002
Cr-Commit-Position: refs/heads/master@{#467822}
Committed: https://chromium.googlesource.com/chromium/src/+/649deb578bb3df05d80ebc164148f0ce3597f52c

[mcasas, 2017-04-26 22:26:49]

Description was changed from

==========
RELAND: GeoLocation: add support for GmsCore location provider

Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)
==========

to

==========
RELAND: GeoLocation: add support for GmsCore location provider

Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)
==========

[mcasas, 2017-04-26 22:36:12]

Description was changed from

==========
RELAND: GeoLocation: add support for GmsCore location provider

Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)
==========

to

==========
RELAND: GeoLocation: add support for GmsCore location provider

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed.


[1]
https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src...


Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)
==========

[mcasas, 2017-04-26 23:59:45]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-04-26 23:59:52]

Patchset #1 (id:20001) has been deleted

[mcasas, 2017-04-27 01:36:06]

mcasas@chromium.org changed reviewers:
+ sgurun@chromium.org

[mcasas, 2017-04-27 01:36:07]

sgurun@ as talked, ptal

[mcasas, 2017-04-27 01:52:47]

Description was changed from

==========
RELAND: GeoLocation: add support for GmsCore location provider

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed.


[1]
https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src...


Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)
==========

to

==========
RELAND: GeoLocation: add support for GmsCore location provider

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed. This CL adds a flag to
enable
explicitly the GMScore provider, and uses it
from Chrome.


[1]
https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src...


Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)
==========

[sgurun-gerrit only, 2017-04-27 17:14:42]

sgurun@chromium.org changed reviewers:
+ tedchoc@chromium.org

[sgurun-gerrit only, 2017-04-27 17:15:04]

On 2017/04/27 01:36:07, mcasas wrote:
> sgurun@ as talked, ptal

lgtm, 

cc'ing Ted as he owns chrome/android

[mcasas, 2017-04-27 18:07:24]

Description was changed from

==========
RELAND: GeoLocation: add support for GmsCore location provider

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed. This CL adds a flag to
enable
explicitly the GMScore provider, and uses it
from Chrome.


[1]
https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src...


Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)
==========

to

==========
RELAND: GeoLocation: add support for GmsCore location provider

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed. This CL adds a flag to
enable
explicitly the GMScore provider, and uses it
from Chrome.


[1]
https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src...


Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)

TBR=  aelias@chromium.org, reillyg@chromium.org, agrieve@chromium.org who LGTM
PS1
==========

[Ted C, 2017-04-27 18:20:44]

https://codereview.chromium.org/2836213002/diff/60001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2836213002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:393:
LocationProviderFactory.useGmsCoreLocationProvider();
Not everything in Chrome goes through ChromeActivity (preferences for example).

If we want this to be more universally done, I think we should put it in:

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

I think we could put this in pre or post native as it simply sets a boolean.  If
we think there is ever a chance we'll use this before native then let's just do
pre as a "pre"caution (yuk, yuk, yuk)

[mcasas, 2017-04-27 18:35:31]

ptal

https://codereview.chromium.org/2836213002/diff/60001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2836213002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:393:
LocationProviderFactory.useGmsCoreLocationProvider();
On 2017/04/27 18:20:44, Ted C wrote:
> Not everything in Chrome goes through ChromeActivity (preferences for
example).
> 
> If we want this to be more universally done, I think we should put it in:
> 
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
> 
> I think we could put this in pre or post native as it simply sets a boolean. 
If
> we think there is ever a chance we'll use this before native then let's just
do
> pre as a "pre"caution (yuk, yuk, yuk)

Done, thanks.  I moved it to 
handlePreNativeInitialization() since the 
LocationProviderFactory is called from native.

[Ted C, 2017-04-27 18:37:39]

On 2017/04/27 18:35:31, mcasas wrote:
> ptal
> 
>
https://codereview.chromium.org/2836213002/diff/60001/chrome/android/java/src...
> File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
> (right):
> 
>
https://codereview.chromium.org/2836213002/diff/60001/chrome/android/java/src...
> chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:393:
> LocationProviderFactory.useGmsCoreLocationProvider();
> On 2017/04/27 18:20:44, Ted C wrote:
> > Not everything in Chrome goes through ChromeActivity (preferences for
> example).
> > 
> > If we want this to be more universally done, I think we should put it in:
> > 
> >
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
> > 
> > I think we could put this in pre or post native as it simply sets a boolean.

> If
> > we think there is ever a chance we'll use this before native then let's just
> do
> > pre as a "pre"caution (yuk, yuk, yuk)
> 
> Done, thanks.  I moved it to 
> handlePreNativeInitialization() since the 
> LocationProviderFactory is called from native.

lgtm

[mcasas, 2017-04-27 19:33:49]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-04-27 19:33:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sgurun@chromium.org
Link to the patchset: https://codereview.chromium.org/2836213002/#ps80001
(title: "Moved useGmsCoreLocationProvider() call to
handlePreNativeInitialization()")

[commit-bot: I haz the power, 2017-04-27 19:35:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:00:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:00:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mcasas, 2017-04-27 20:07:29]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:07:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-04-27 20:22:08]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-04-27 21:01:44]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:02:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 22:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:35:02]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-04-27 22:36:54]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-04-27 22:36:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, sgurun@chromium.org
Link to the patchset: https://codereview.chromium.org/2836213002/#ps100001
(title: "Added device/geolocation/android/java to chrome/android/java/DEPS")

[commit-bot: I haz the power, 2017-04-27 22:38:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:55:55]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493332614474590,
"parent_rev": "1423a66d68562cda92de55d3f247ae1c8a155241", "commit_rev":
"649deb578bb3df05d80ebc164148f0ce3597f52c"}

[commit-bot: I haz the power, 2017-04-28 01:56:30]

Description was changed from

==========
RELAND: GeoLocation: add support for GmsCore location provider

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed. This CL adds a flag to
enable
explicitly the GMScore provider, and uses it
from Chrome.


[1]
https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src...


Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)

TBR=  aelias@chromium.org, reillyg@chromium.org, agrieve@chromium.org who LGTM
PS1
==========

to

==========
RELAND: GeoLocation: add support for GmsCore location provider

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed. This CL adds a flag to
enable
explicitly the GMScore provider, and uses it
from Chrome.


[1]
https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src...


Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed:
https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546...

patch from issue 2809813002 at patchset 260001
(http://crrev.com/2809813002#ps260001)

TBR=  aelias@chromium.org, reillyg@chromium.org, agrieve@chromium.org who LGTM
PS1

Review-Url: https://codereview.chromium.org/2836213002
Cr-Commit-Position: refs/heads/master@{#467822}
Committed:
https://chromium.googlesource.com/chromium/src/+/649deb578bb3df05d80ebc164148...
==========

[commit-bot: I haz the power, 2017-04-28 01:56:31]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/649deb578bb3df05d80ebc164148...

[estevenson, 2017-05-01 15:55:25]

On 2017/04/28 01:56:31, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:100001) as
>
https://chromium.googlesource.com/chromium/src/+/649deb578bb3df05d80ebc164148...

FYI - this added 60kb to Chrome on Android. No action is required (unless you
can think of an obvious way to reduce the overhead).

Link to size graph:
https://chromeperf.appspot.com/report?sid=cfc29eed1238fd38fb5e6cf83bdba6c619b...