RELAND: GeoLocation: add support for GmsCore location provider

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 131 matching lines @@
 import org.chromium.chrome.browser.widget.bottomsheet.BottomSheetContentController;
 import org.chromium.chrome.browser.widget.bottomsheet.EmptyBottomSheetObserver;
 import org.chromium.components.bookmarks.BookmarkId;
 import org.chromium.content.browser.ContentVideoView;
 import org.chromium.content.browser.ContentViewCore;
 import org.chromium.content.common.ContentSwitches;
 import org.chromium.content_public.browser.ContentBitmapCallback;
 import org.chromium.content_public.browser.LoadUrlParams;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.content_public.browser.readback_types.ReadbackResponse;
+import org.chromium.device.geolocation.LocationProviderFactory;
 import org.chromium.policy.CombinedPolicyProvider;
 import org.chromium.policy.CombinedPolicyProvider.PolicyChangeListener;
 import org.chromium.printing.PrintManagerDelegateImpl;
 import org.chromium.printing.PrintingController;
 import org.chromium.printing.PrintingControllerImpl;
 import org.chromium.ui.base.ActivityWindowAndroid;
 import org.chromium.ui.base.DeviceFormFactor;
 import org.chromium.ui.base.PageTransition;
 import org.chromium.ui.base.WindowAndroid;
 import org.chromium.ui.widget.Toast;
@@ skipping 219 matching lines @@
 
             mBottomSheetContentController =
                     (BottomSheetContentController) ((ViewStub) findViewById(R.id.bottom_nav_stub))
                             .inflate();
             int controlContainerHeight =
                     ((ControlContainer) findViewById(R.id.control_container)).getView().getHeight();
             mBottomSheetContentController.init(
                     mBottomSheet, controlContainerHeight, mTabModelSelector, this);
         }
         ((BottomContainer) findViewById(R.id.bottom_container)).initialize(mFullscreenManager);
+
+        LocationProviderFactory.useGmsCoreLocationProvider();

[Ted C, 2017/04/27 18:20:44]

Not everything in Chrome goes through ChromeActivity (preferences for example).

If we want this to be more universally done, I think we should put it in:

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

I think we could put this in pre or post native as it simply sets a boolean.  If
we think there is ever a chance we'll use this before native then let's just do
pre as a "pre"caution (yuk, yuk, yuk)

[mcasas, 2017/04/27 18:35:31]

Done, thanks.  I moved it to 
handlePreNativeInitialization() since the 
LocationProviderFactory is called from native.

     }
 
     @Override
     protected View getViewToBeDrawnBeforeInitializingNative() {
         View controlContainer = findViewById(R.id.control_container);
         return controlContainer != null ? controlContainer
                 : super.getViewToBeDrawnBeforeInitializingNative();
     }
 
     /**
@@ skipping 1753 matching lines @@
      * draw over VR contents should be hidden in this call.
      */
     public void onEnterVr() {}
 
     /**
      * Called when VR mode using this activity is exited. Any state set for VR should be restored
      * in this call, including showing 2D UI that was hidden.
      */
     public void onExitVr() {}
 }