Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h

Issue 2836183002: [DMC #6] Add TextMatchMarkerListImpl (Closed)
Patch Set: final Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h
diff --git a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h
similarity index 58%
rename from third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h
rename to third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h
index 4f7cad205a8ca99b2ea76c9443b513d565f48630..b0875049e277b63ab6660b5eb77050f3869afdcc 100644
--- a/third_party/WebKit/Source/core/editing/markers/GenericDocumentMarkerListImpl.h
+++ b/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h
@@ -2,21 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef GenericDocumentMarkerListImpl_h
-#define GenericDocumentMarkerListImpl_h
+#ifndef TextMatchMarkerListImpl_h
+#define TextMatchMarkerListImpl_h
#include "core/editing/markers/DocumentMarkerList.h"
namespace blink {
-class RenderedDocumentMarker;
-
-// Temporary implementation of DocumentMarkerList that can handle
-// DocumentMarkers of all MarkerTypes. This will be removed once we have
-// specialized implementations for every MarkerType.
-class GenericDocumentMarkerListImpl final : public DocumentMarkerList {
+// Implementation of DocumentMarkerList for TextMatch markers.
+// Markers are kept sorted by start offset, under the assumption that
+// TextMatch markers are typically inserted in an order.
+class CORE_EXPORT TextMatchMarkerListImpl final : public DocumentMarkerList {
public:
- GenericDocumentMarkerListImpl(DocumentMarker::MarkerType);
+ TextMatchMarkerListImpl() = default;
// DocumentMarkerList implementations
DocumentMarker::MarkerType MarkerType() const final;
@@ -33,16 +31,14 @@ class GenericDocumentMarkerListImpl final : public DocumentMarkerList {
bool ShiftMarkers(unsigned offset,
unsigned old_length,
unsigned new_length) final;
-
- DECLARE_TRACE();
+ DECLARE_VIRTUAL_TRACE();
private:
- const DocumentMarker::MarkerType marker_type_;
HeapVector<Member<RenderedDocumentMarker>> markers_;
- DISALLOW_COPY_AND_ASSIGN(GenericDocumentMarkerListImpl);
+ DISALLOW_COPY_AND_ASSIGN(TextMatchMarkerListImpl);
};
} // namespace blink
-#endif // GenericDocumentMarkerListImpl_h
+#endif // TextMatchMarkerListImpl_h

Powered by Google App Engine
This is Rietveld 408576698