third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2836143003: Invalidate border/outline on color change only if they use current color

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2836143003: Invalidate border/outline on color change only if they use current color (Closed)

Patch Set: rebaselined Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 57050627de17fafbb5179957e1627db37958916b..2572a01660ce351788e1b74858d0da5f8774473e 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -1543,7 +1543,8 @@ StyleDifference LayoutObject::AdjustStyleDifference(

// needed if we have style or text affected by these properties.

if (diff.TextDecorationOrColorChanged() &&

!diff.NeedsFullPaintInvalidation()) {

- if (Style()->HasBorder() || Style()->HasOutline() ||

+ if (Style()->HasBorderColorReferencingCurrentColor() ||

+ Style()->HasOutlineWithCurrentColor() ||

Style()->HasBackgroundRelatedColorReferencingCurrentColor() ||

// Skip any text nodes that do not contain text boxes. Whitespace cannot

// be skipped or we will miss invalidating decorations (e.g.,