Revert of Move most of FrameLoader::CheckCompleted() to Document

Revert of Move most of FrameLoader::CheckCompleted() to Document (patchset #8 id:140001 of https://codereview.chromium.org/2809733003/ )

Reason for revert:
Causes DCHECKs in webkit_tests when running with --site-per-process, which blocks CQ jobs requiring the linux_site_isolation bot.

Example failure: https://storage.googleapis.com/chromium-layout-test-archives/Site_Isolation_Win/18859/layout-test-results/results.html

STDERR: [4584:5888:0421/170621.194:3990474:FATAL:document.cpp(4648)] Check failed: GetFrame() && GetFrame()->Owner(). 
STDERR: Backtrace:
STDERR: 	base::debug::StackTrace::StackTrace [0x01E9EC87+55]
STDERR: 	base::debug::StackTrace::StackTrace [0x01EC8D5A+10]
STDERR: 	blink::Document::WillChangeFrameOwnerProperties [0x02DB7391+90]
STDERR: 	blink::HTMLFrameElementBase::SetScrollingMode [0x02F4655F+57]
STDERR: 	blink::HTMLFrameElementBase::ParseAttribute [0x02F4638A+490]
STDERR: 	blink::HTMLIFrameElement::ParseAttribute [0x02F3C9AC+604]
STDERR: 	blink::Element::AttributeChanged [0x02DBC38F+111]
STDERR: 	blink::HTMLElement::AttributeChanged [0x02F26590+16]
STDERR: 	blink::Element::DidModifyAttribute [0x02DBDD8C+67]
STDERR: 	blink::Element::setAttribute [0x02DC7B6E+222]
STDERR: 	blink::V8HTMLFrameElement::scrollingAttributeSetterCallback [0x02BA8131+129]
STDERR: 	v8::internal::FunctionCallbackArguments::Call [0x01698E9D+157]
STDERR: 	v8::internal::Isolate::typed_array_prototype [0x0173761C+1788]
STDERR: 	v8::internal::Builtins::InvokeApiFunction [0x01738931+849]
STDERR: 	v8::internal::Object::SetPropertyWithAccessor [0x01AFA1E8+808]
STDERR: 	v8::internal::Object::SetPropertyInternal [0x01AF9E2C+588]
STDERR: 	v8::internal::Object::SetProperty [0x01AF9A7D+45]
STDERR: 	v8::internal::StoreIC::Store [0x01A4F1DB+491]
STDERR: 	v8::internal::BinaryOpICState::UseInlinedSmiCode [0x01A551EA+10074]
STDERR: 	v8::internal::Runtime_StoreIC_Miss [0x01A4D32C+220]

Original issue's description:
> Move most of FrameLoader::CheckCompleted() to Document
> 
> Split out the the parts that are specific to the committed Document, and
> move those to a new Document::CheckCompleted(). Most current callers of
> FrameLoader::CheckCompleted() will now call Document::CheckCompleted()
> instead. Rename the remained of FrameLoader::CheckCompleted() to
> DidFinishNavigation(), and have it handling the logic that is tied to
> setting Frame::loading_ to false and firing DidStopLoading() callbacks.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2809733003
> Cr-Commit-Position: refs/heads/master@{#466470}
> Committed: https://chromium.googlesource.com/chromium/src/+/37861ef99134d28395b1891a25edb0b750a7011e

TBR=yhirano@chromium.org,mkwst@chromium.org,hiroshige@chromium.org,dfalcantara@chromium.org,boliu@chromium.org,japhet@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2836103003
Cr-Commit-Position: refs/heads/master@{#466757}
Committed: https://chromium.googlesource.com/chromium/src/+/f88c2c4ef00eb6cfc5a8c3a7cfa686ccd80afae5

[nasko, 2017-04-24 18:47:08]

The CQ bit was checked by nasko@chromium.org

[nasko, 2017-04-24 18:47:08]

Created Revert of Move most of FrameLoader::CheckCompleted() to Document

[commit-bot: I haz the power, 2017-04-24 18:48:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 20:55:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493059628440250, "parent_rev":
"ddb812975b721aee41c39a12ac739eab0e8b053f", "commit_rev":
"f88c2c4ef00eb6cfc5a8c3a7cfa686ccd80afae5"}

[commit-bot: I haz the power, 2017-04-24 20:55:39]

Description was changed from

==========
Revert of Move most of FrameLoader::CheckCompleted() to Document (patchset #8
id:140001 of https://codereview.chromium.org/2809733003/ )

Reason for revert:
Causes DCHECKs in webkit_tests when running with --site-per-process, which
blocks CQ jobs requiring the linux_site_isolation bot.

Example failure:
https://storage.googleapis.com/chromium-layout-test-archives/Site_Isolation_W...

STDERR: [4584:5888:0421/170621.194:3990474:FATAL:document.cpp(4648)] Check
failed: GetFrame() && GetFrame()->Owner(). 
STDERR: Backtrace:
STDERR: 	base::debug::StackTrace::StackTrace [0x01E9EC87+55]
STDERR: 	base::debug::StackTrace::StackTrace [0x01EC8D5A+10]
STDERR: 	blink::Document::WillChangeFrameOwnerProperties [0x02DB7391+90]
STDERR: 	blink::HTMLFrameElementBase::SetScrollingMode [0x02F4655F+57]
STDERR: 	blink::HTMLFrameElementBase::ParseAttribute [0x02F4638A+490]
STDERR: 	blink::HTMLIFrameElement::ParseAttribute [0x02F3C9AC+604]
STDERR: 	blink::Element::AttributeChanged [0x02DBC38F+111]
STDERR: 	blink::HTMLElement::AttributeChanged [0x02F26590+16]
STDERR: 	blink::Element::DidModifyAttribute [0x02DBDD8C+67]
STDERR: 	blink::Element::setAttribute [0x02DC7B6E+222]
STDERR: 	blink::V8HTMLFrameElement::scrollingAttributeSetterCallback
[0x02BA8131+129]
STDERR: 	v8::internal::FunctionCallbackArguments::Call [0x01698E9D+157]
STDERR: 	v8::internal::Isolate::typed_array_prototype [0x0173761C+1788]
STDERR: 	v8::internal::Builtins::InvokeApiFunction [0x01738931+849]
STDERR: 	v8::internal::Object::SetPropertyWithAccessor [0x01AFA1E8+808]
STDERR: 	v8::internal::Object::SetPropertyInternal [0x01AF9E2C+588]
STDERR: 	v8::internal::Object::SetProperty [0x01AF9A7D+45]
STDERR: 	v8::internal::StoreIC::Store [0x01A4F1DB+491]
STDERR: 	v8::internal::BinaryOpICState::UseInlinedSmiCode [0x01A551EA+10074]
STDERR: 	v8::internal::Runtime_StoreIC_Miss [0x01A4D32C+220]

Original issue's description:
> Move most of FrameLoader::CheckCompleted() to Document
> 
> Split out the the parts that are specific to the committed Document, and
> move those to a new Document::CheckCompleted(). Most current callers of
> FrameLoader::CheckCompleted() will now call Document::CheckCompleted()
> instead. Rename the remained of FrameLoader::CheckCompleted() to
> DidFinishNavigation(), and have it handling the logic that is tied to
> setting Frame::loading_ to false and firing DidStopLoading() callbacks.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2809733003
> Cr-Commit-Position: refs/heads/master@{#466470}
> Committed:
https://chromium.googlesource.com/chromium/src/+/37861ef99134d28395b1891a25ed...

TBR=yhirano@chromium.org,mkwst@chromium.org,hiroshige@chromium.org,dfalcantar...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
==========

to

==========
Revert of Move most of FrameLoader::CheckCompleted() to Document (patchset #8
id:140001 of https://codereview.chromium.org/2809733003/ )

Reason for revert:
Causes DCHECKs in webkit_tests when running with --site-per-process, which
blocks CQ jobs requiring the linux_site_isolation bot.

Example failure:
https://storage.googleapis.com/chromium-layout-test-archives/Site_Isolation_W...

STDERR: [4584:5888:0421/170621.194:3990474:FATAL:document.cpp(4648)] Check
failed: GetFrame() && GetFrame()->Owner(). 
STDERR: Backtrace:
STDERR: 	base::debug::StackTrace::StackTrace [0x01E9EC87+55]
STDERR: 	base::debug::StackTrace::StackTrace [0x01EC8D5A+10]
STDERR: 	blink::Document::WillChangeFrameOwnerProperties [0x02DB7391+90]
STDERR: 	blink::HTMLFrameElementBase::SetScrollingMode [0x02F4655F+57]
STDERR: 	blink::HTMLFrameElementBase::ParseAttribute [0x02F4638A+490]
STDERR: 	blink::HTMLIFrameElement::ParseAttribute [0x02F3C9AC+604]
STDERR: 	blink::Element::AttributeChanged [0x02DBC38F+111]
STDERR: 	blink::HTMLElement::AttributeChanged [0x02F26590+16]
STDERR: 	blink::Element::DidModifyAttribute [0x02DBDD8C+67]
STDERR: 	blink::Element::setAttribute [0x02DC7B6E+222]
STDERR: 	blink::V8HTMLFrameElement::scrollingAttributeSetterCallback
[0x02BA8131+129]
STDERR: 	v8::internal::FunctionCallbackArguments::Call [0x01698E9D+157]
STDERR: 	v8::internal::Isolate::typed_array_prototype [0x0173761C+1788]
STDERR: 	v8::internal::Builtins::InvokeApiFunction [0x01738931+849]
STDERR: 	v8::internal::Object::SetPropertyWithAccessor [0x01AFA1E8+808]
STDERR: 	v8::internal::Object::SetPropertyInternal [0x01AF9E2C+588]
STDERR: 	v8::internal::Object::SetProperty [0x01AF9A7D+45]
STDERR: 	v8::internal::StoreIC::Store [0x01A4F1DB+491]
STDERR: 	v8::internal::BinaryOpICState::UseInlinedSmiCode [0x01A551EA+10074]
STDERR: 	v8::internal::Runtime_StoreIC_Miss [0x01A4D32C+220]

Original issue's description:
> Move most of FrameLoader::CheckCompleted() to Document
> 
> Split out the the parts that are specific to the committed Document, and
> move those to a new Document::CheckCompleted(). Most current callers of
> FrameLoader::CheckCompleted() will now call Document::CheckCompleted()
> instead. Rename the remained of FrameLoader::CheckCompleted() to
> DidFinishNavigation(), and have it handling the logic that is tied to
> setting Frame::loading_ to false and firing DidStopLoading() callbacks.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2809733003
> Cr-Commit-Position: refs/heads/master@{#466470}
> Committed:
https://chromium.googlesource.com/chromium/src/+/37861ef99134d28395b1891a25ed...

TBR=yhirano@chromium.org,mkwst@chromium.org,hiroshige@chromium.org,dfalcantar...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2836103003
Cr-Commit-Position: refs/heads/master@{#466757}
Committed:
https://chromium.googlesource.com/chromium/src/+/f88c2c4ef00eb6cfc5a8c3a7cfa6...
==========

[commit-bot: I haz the power, 2017-04-24 20:55:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f88c2c4ef00eb6cfc5a8c3a7cfa6...