third_party/WebKit/Source/core/loader/FrameFetchContext.cpp - Issue 2836103003: Revert of Move most of FrameLoader::CheckCompleted() to Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2836103003: Revert of Move most of FrameLoader::CheckCompleted() to Document (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

index 9ce771840c4b86d08c2a4e4b5812c4f8ed3ea308..aad2404223ad5a4d6ec402328f81e4ac9c6f6034 100644

--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

@@ -616,11 +616,10 @@

}

void FrameFetchContext::DidLoadResource(Resource* resource) {

- if (!GetDocument())

- return;

- FirstMeaningfulPaintDetector::From(*GetDocument()).CheckNetworkStable();

if (resource->IsLoadEventBlockingResourceType())

- GetDocument()->CheckCompleted();

+ GetFrame()->Loader().CheckCompleted();

+ if (GetDocument())

+ FirstMeaningfulPaintDetector::From(*GetDocument()).CheckNetworkStable();

}

void FrameFetchContext::AddResourceTiming(const ResourceTimingInfo& info) {