Componentize safe_browsing: move threat_details* to component.

Componentize safe_browsing: move threat_details* to component.

Move threat_details* to the safe_browsing component and
update build files and dependencies.

BUG=700351, 688629
Review-Url: https://codereview.chromium.org/2836103002
Cr-Commit-Position: refs/heads/master@{#469014}
Committed: https://chromium.googlesource.com/chromium/src/+/42a7b7f4765a74b3a61bcf1940636f27f4a2a38d

[timvolodine, 2017-04-24 17:19:19]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 17:20:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 17:24:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 17:24:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[timvolodine, 2017-04-24 17:38:30]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 17:38:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 18:01:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 18:01:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[timvolodine, 2017-04-24 18:08:36]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 18:09:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 19:28:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 19:28:34]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2017-04-25 12:28:34]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 12:28:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 13:49:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 13:49:21]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2017-04-25 15:52:13]

Description was changed from

==========
Componentize safe_browsing: move threat_details* to component.

WIP

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: move threat_details* to component.

Move the threat_details* to component and update dependencies.

BUG=700351, 688629
==========

[timvolodine, 2017-04-25 15:52:13]

timvolodine@chromium.org changed reviewers:
+ jialiul@chromium.org

[timvolodine, 2017-04-25 15:57:15]

jialiul@: please take a look

+cc:nparker@

[Jialiu Lin, 2017-04-26 18:03:31]

Sorry for my late reply. I was on vacation from April 22-25.

Could you put threat_details.*, threat_details_cache.*, threat_details_history.*
directly in components/safe_browsing/? Since all the other files under
components/safe_browsing/ are originally moved from
chrome/browser/safe_browsing. No need to create an extra browser layer. 

Thanks!

[Jialiu Lin, 2017-05-01 20:33:14]

jialiul@chromium.org changed reviewers:
+ lpz@chromium.org

[Jialiu Lin, 2017-05-01 20:33:15]

+lpz@ as reviewer too, since he has been actively working on ThreatDetails
related code.

[timvolodine, 2017-05-02 17:20:28]

On 2017/04/26 18:03:31, Jialiu Lin wrote:
> Sorry for my late reply. I was on vacation from April 22-25.
> 
> Could you put threat_details.*, threat_details_cache.*,
threat_details_history.*
> directly in components/safe_browsing/? Since all the other files under
> components/safe_browsing/ are originally moved from
> chrome/browser/safe_browsing. No need to create an extra browser layer. 
> 
> Thanks!

No worries, thanks for having a look. Actually, while considering the larger
context (i.e. crbug.com/668515) I think the browser/ layer would be more clear.
I've made a draft doc on the structure of the component https://goo.gl/2R6K3G,
wdyt?

[Jialiu Lin, 2017-05-02 17:32:44]

Restructure safe_browsing and safe_browsing_db LGTM. Thanks for creating this
doc.

This CL LGTM too. You're right, if we are going to merge c/safe_browsing/ and
c/safe_browsing_db, it makes more sense to have a browser directory. 

Thanks!

[lpz, 2017-05-02 17:33:46]

lgtm

[timvolodine, 2017-05-02 17:42:45]

On 2017/05/02 17:33:46, lpz wrote:
> lgtm

Thanks all!

[timvolodine, 2017-05-02 17:42:51]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2017-05-02 17:43:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2017-05-02 17:43:54]

Description was changed from

==========
Componentize safe_browsing: move threat_details* to component.

Move the threat_details* to component and update dependencies.

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: move threat_details* to component.

Move threat_details* to component and update build files and
dependencies.

BUG=700351, 688629
==========

[timvolodine, 2017-05-02 17:44:22]

Description was changed from

==========
Componentize safe_browsing: move threat_details* to component.

Move threat_details* to component and update build files and
dependencies.

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: move threat_details* to component.

Move threat_details* to the safe_browsing component and
update build files and dependencies.

BUG=700351, 688629
==========

[commit-bot: I haz the power, 2017-05-02 17:54:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 17:54:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[timvolodine, 2017-05-02 17:55:48]

timvolodine@chromium.org changed reviewers:
+ jam@chromium.org

[timvolodine, 2017-05-02 17:55:49]

+jam@ for overall RS

[jam, 2017-05-02 19:58:33]

On 2017/05/02 17:55:49, timvolodine wrote:
> +jam@ for overall RS

please specify which files you want me to review. most of these already have
owners.

[timvolodine, 2017-05-03 11:28:29]

On 2017/05/02 19:58:33, jam wrote:
> On 2017/05/02 17:55:49, timvolodine wrote:
> > +jam@ for overall RS
> 
> please specify which files you want me to review. most of these already have
> owners.

presubmit complains with:

** Presubmit ERRORS **
You need LGTM from owners of depends-on paths in DEPS that were modified in this
CL:
    '+components/history/core/browser',
    '+content/public/browser',
    '+net/http',
    '+net/traffic_annotation',

Suggested missing target path OWNERS:
    jam@chromium.org

so I assume the DEPS files please..

[jam, 2017-05-03 15:56:01]

lgtm

[timvolodine, 2017-05-03 16:47:09]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2017-05-03 16:47:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 17:15:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493830029062020,
"parent_rev": "1f17747585f90c358df6d8ffbe010893f72d30fc", "commit_rev":
"42a7b7f4765a74b3a61bcf1940636f27f4a2a38d"}

[commit-bot: I haz the power, 2017-05-03 17:15:29]

Description was changed from

==========
Componentize safe_browsing: move threat_details* to component.

Move threat_details* to the safe_browsing component and
update build files and dependencies.

BUG=700351, 688629
==========

to

==========
Componentize safe_browsing: move threat_details* to component.

Move threat_details* to the safe_browsing component and
update build files and dependencies.

BUG=700351, 688629

Review-Url: https://codereview.chromium.org/2836103002
Cr-Commit-Position: refs/heads/master@{#469014}
Committed:
https://chromium.googlesource.com/chromium/src/+/42a7b7f4765a74b3a61bcf194063...
==========

[commit-bot: I haz the power, 2017-05-03 17:15:31]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/42a7b7f4765a74b3a61bcf194063...