Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: components/safe_browsing/browser/threat_details.h

Issue 2836103002: Componentize safe_browsing: move threat_details* to component. (Closed)
Patch Set: fix spelling and typos Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing/browser/DEPS ('k') | components/safe_browsing/browser/threat_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/browser/threat_details.h
diff --git a/chrome/browser/safe_browsing/threat_details.h b/components/safe_browsing/browser/threat_details.h
similarity index 95%
rename from chrome/browser/safe_browsing/threat_details.h
rename to components/safe_browsing/browser/threat_details.h
index abd1747be15ae0510743831c61544e119a00d2f0..882458b64d5ad75aa9b6fa4c0e72dedb00100ad0 100644
--- a/chrome/browser/safe_browsing/threat_details.h
+++ b/components/safe_browsing/browser/threat_details.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_SAFE_BROWSING_THREAT_DETAILS_H_
-#define CHROME_BROWSER_SAFE_BROWSING_THREAT_DETAILS_H_
+#ifndef COMPONENTS_SAFE_BROWSING_BROWSER_THREAT_DETAILS_H_
+#define COMPONENTS_SAFE_BROWSING_BROWSER_THREAT_DETAILS_H_
// A class that encapsulates the detailed threat reports sent when
// users opt-in to do so from the safe browsing warning page.
@@ -53,7 +53,7 @@ using ResourceMap =
// Maps a key of an HTML element to its corresponding HTMLElement proto message.
// HTML Element keys have the form "<frame_id>-<node_id>", where |frame_id| is
// the FrameTree NodeID of the render frame containing the element, and
-// |node_id| is a seqeuntial ID for the element generated by the renderer.
+// |node_id| is a sequential ID for the element generated by the renderer.
using ElementMap = base::hash_map<std::string, std::unique_ptr<HTMLElement>>;
// Maps a URL to some HTML Elements. Used to maintain parent/child relationship
@@ -173,7 +173,7 @@ class ThreatDetails : public base::RefCountedThreadSafe<
// |element_node_id| is a unique ID of the element within the render frame.
// |tag_name| is the tag of the element. |parent_element_node_id| is the
// unique ID of the parent element with the render frame. |attributes|
- // containes the names and values of the element's attributes.|resource| is
+ // contains the names and values of the element's attributes.|resource| is
// set if this element is a resource.
void AddDomElement(const int frame_tree_node_id,
const std::string& frame_url,
@@ -222,8 +222,8 @@ class ThreatDetails : public base::RefCountedThreadSafe<
// associated with a parent Element in the parent frame.
bool ambiguous_dom_;
- // The factory used to instanciate SafeBrowsingBlockingPage objects.
- // Usefull for tests, so they can provide their own implementation of
+ // The factory used to instantiate SafeBrowsingBlockingPage objects.
+ // Useful for tests, so they can provide their own implementation of
// SafeBrowsingBlockingPage.
static ThreatDetailsFactory* factory_;
@@ -259,4 +259,4 @@ class ThreatDetailsFactory {
} // namespace safe_browsing
-#endif // CHROME_BROWSER_SAFE_BROWSING_THREAT_DETAILS_H_
+#endif // COMPONENTS_SAFE_BROWSING_BROWSER_THREAT_DETAILS_H_
« no previous file with comments | « components/safe_browsing/browser/DEPS ('k') | components/safe_browsing/browser/threat_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698