Make Android notifications rely on the native notification flag

Make Android notifications rely on the native notification flag

Right now we have specific ifdefs for android as opposed to just relying on ENABLE_NATIVE_NOTIFICATIONS + features::kNativeNotifications like all other platforms.

BUG=

Review-Url: https://codereview.chromium.org/2836093002
Cr-Commit-Position: refs/heads/master@{#467316}
Committed: https://chromium.googlesource.com/chromium/src/+/484fd1babac290f3e34b4d61b6bf716049fe536a

[Miguel Garcia, 2017-04-24 17:15:24]

The CQ bit was checked by miguelg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 17:15:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 18:01:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 18:01:52]

Dry run: This issue passed the CQ dry run.

[Miguel Garcia, 2017-04-25 15:27:48]

The CQ bit was checked by miguelg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 15:28:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Miguel Garcia, 2017-04-25 15:53:48]

Description was changed from

==========
Enable Android native notifications

BUG=
==========

to

==========
Make Android notifications rely on the native notification flag

Right now we have specific ifdefs for android as opposed to just relying on
ENABLE_NATIVE_NOTIFICATIONS + features::kNativeNotifications like all other
platforms.

BUG=
==========

[commit-bot: I haz the power, 2017-04-25 16:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 16:22:56]

Dry run: This issue passed the CQ dry run.

[Miguel Garcia, 2017-04-25 16:23:46]

miguelg@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-04-25 16:31:29]

lgtm

https://codereview.chromium.org/2836093002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/notification_display_service_factory.cc
(right):

https://codereview.chromium.org/2836093002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notification_display_service_factory.cc:52: // Note
that for android this flag must always be true.
DCHECK?

[Miguel Garcia, 2017-04-26 13:18:24]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2017-04-26 13:18:25]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2836093002/#ps40001
(title: "Add an additional check for Android")

[commit-bot: I haz the power, 2017-04-26 13:18:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 14:08:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493212704004150,
"parent_rev": "86195291fae07e5bb665295e0cb598777100ff34", "commit_rev":
"484fd1babac290f3e34b4d61b6bf716049fe536a"}

[commit-bot: I haz the power, 2017-04-26 14:08:53]

Description was changed from

==========
Make Android notifications rely on the native notification flag

Right now we have specific ifdefs for android as opposed to just relying on
ENABLE_NATIVE_NOTIFICATIONS + features::kNativeNotifications like all other
platforms.

BUG=
==========

to

==========
Make Android notifications rely on the native notification flag

Right now we have specific ifdefs for android as opposed to just relying on
ENABLE_NATIVE_NOTIFICATIONS + features::kNativeNotifications like all other
platforms.

BUG=

Review-Url: https://codereview.chromium.org/2836093002
Cr-Commit-Position: refs/heads/master@{#467316}
Committed:
https://chromium.googlesource.com/chromium/src/+/484fd1babac290f3e34b4d61b6bf...
==========

[commit-bot: I haz the power, 2017-04-26 14:08:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/484fd1babac290f3e34b4d61b6bf...

[Miguel Garcia, 2017-05-03 07:11:33]

https://codereview.chromium.org/2836093002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/notification_display_service_factory.cc
(right):

https://codereview.chromium.org/2836093002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notification_display_service_factory.cc:52: // Note
that for android this flag must always be true.
On 2017/04/25 16:31:29, Peter Beverloo wrote:
> DCHECK?

As discussed offline in addition to the DCHECK I added some code to protect us
against someone accidentally disabling the flag in finch and crash all android
browsers as a result.