Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: chrome/common/chrome_features.cc

Issue 2836093002: Make Android notifications rely on the native notification flag (Closed)
Patch Set: Add an additional check for Android Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/notifications/platform_notification_service_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_features.h" 5 #include "chrome/common/chrome_features.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "extensions/features/features.h" 9 #include "extensions/features/features.h"
10 #include "ppapi/features/features.h" 10 #include "ppapi/features/features.h"
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 217
218 #if defined(OS_WIN) 218 #if defined(OS_WIN)
219 // Enables or disables the ModuleDatabase backend for the conflicts UI. 219 // Enables or disables the ModuleDatabase backend for the conflicts UI.
220 const base::Feature kModuleDatabase{"ModuleDatabase", 220 const base::Feature kModuleDatabase{"ModuleDatabase",
221 base::FEATURE_DISABLED_BY_DEFAULT}; 221 base::FEATURE_DISABLED_BY_DEFAULT};
222 #endif 222 #endif
223 223
224 // Enables the use of native notification centers instead of using the Message 224 // Enables the use of native notification centers instead of using the Message
225 // Center for displaying the toasts. 225 // Center for displaying the toasts.
226 #if BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS) 226 #if BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS)
227 #if defined(OS_MACOSX) 227 #if defined(OS_MACOSX) || defined(OS_ANDROID)
228 const base::Feature kNativeNotifications{"NativeNotifications", 228 const base::Feature kNativeNotifications{"NativeNotifications",
229 base::FEATURE_ENABLED_BY_DEFAULT}; 229 base::FEATURE_ENABLED_BY_DEFAULT};
230 #else 230 #else
231 const base::Feature kNativeNotifications{"NativeNotifications", 231 const base::Feature kNativeNotifications{"NativeNotifications",
232 base::FEATURE_DISABLED_BY_DEFAULT}; 232 base::FEATURE_DISABLED_BY_DEFAULT};
233 #endif 233 #endif
234 #endif // BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS) 234 #endif // BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS)
235 235
236 // If enabled, the list of content suggestions on the New Tab page will contain 236 // If enabled, the list of content suggestions on the New Tab page will contain
237 // pages that the user downloaded for later use. 237 // pages that the user downloaded for later use.
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 return base::FeatureList::IsEnabled(features::kPrefService) || 345 return base::FeatureList::IsEnabled(features::kPrefService) ||
346 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) 346 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
347 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII( 347 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
348 switches::kMusConfig) == switches::kMash; 348 switches::kMusConfig) == switches::kMash;
349 #else 349 #else
350 false; 350 false;
351 #endif 351 #endif
352 } 352 }
353 353
354 } // namespace features 354 } // namespace features
OLDNEW
« no previous file with comments | « chrome/browser/notifications/platform_notification_service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698