Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2835973003: MD Settings: Network: SIM unlock: Fix focus and cancel (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

MD Settings: Network: SIM unlock: Fix focus and cancel This CL: * Focuses the first input field for all sim dialogs. * Fixes the toggle logic when the dialog is canceled. BUG=695409 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2821743002 Cr-Commit-Position: refs/heads/master@{#465021} (cherry picked from commit 780ef7b430dc6976831ae4f952cf34579b101f70) Review-Url: https://codereview.chromium.org/2835973003 . Cr-Commit-Position: refs/branch-heads/3071@{#185} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/cd306d8a99765cd2c9cbd05f39a93bacd9cfd078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M chrome/browser/resources/settings/internet_page/network_siminfo.html View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_siminfo.js View 7 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
stevenjb
3 years, 8 months ago (2017-04-25 00:13:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd306d8a99765cd2c9cbd05f39a93bacd9cfd078.

Powered by Google App Engine
This is Rietveld 408576698