MD Settings: Network: SIM unlock: Fix focus and cancel

MD Settings: Network: SIM unlock: Fix focus and cancel

This CL:
* Focuses the first input field for all sim dialogs.
* Fixes the toggle logic when the dialog is canceled.

BUG=695409
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2821743002
Cr-Commit-Position: refs/heads/master@{#465021}
Committed: https://chromium.googlesource.com/chromium/src/+/780ef7b430dc6976831ae4f952cf34579b101f70

[stevenjb, 2017-04-14 21:08:53]

Description was changed from

==========
MD Settings: Network: SIM unlock: Fix focus and cancel

This CL:
* Focuses the first input field for all sim dialogs.
* Fixes the toggle logic when the dialog is canceled.

BUG=695409
==========

to

==========
MD Settings: Network: SIM unlock: Fix focus and cancel

This CL:
* Focuses the first input field for all sim dialogs.
* Fixes the toggle logic when the dialog is canceled.

BUG=695409
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-17 17:49:13]

stevenjb@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2017-04-17 17:57:17]

https://codereview.chromium.org/2821743002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_siminfo.js (right):

https://codereview.chromium.org/2821743002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_siminfo.js:74:
networkPropertiesChanged_: function() {
@private missing here and at |pukRequiredChanged_| below.

https://codereview.chromium.org/2821743002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_siminfo.js:128:
this.$.enterPin.focus();
Can we use the |autofocus| attribute instead? See example at
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/on_sta...

Same question for other focus() calls below.

[stevenjb, 2017-04-17 18:08:35]

https://codereview.chromium.org/2821743002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_siminfo.js (right):

https://codereview.chromium.org/2821743002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_siminfo.js:74:
networkPropertiesChanged_: function() {
On 2017/04/17 17:57:17, dpapad wrote:
> @private missing here and at |pukRequiredChanged_| below.

Done.

https://codereview.chromium.org/2821743002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_siminfo.js:128:
this.$.enterPin.focus();
On 2017/04/17 17:57:17, dpapad wrote:
> Can we use the |autofocus| attribute instead? See example at
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/on_sta...
> 
> Same question for other focus() calls below.

Ah, yes, indeed we can. Done.

[dpapad, 2017-04-17 19:44:09]

LGTM

[stevenjb, 2017-04-17 20:08:46]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-17 20:09:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 21:22:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492459726043580,
"parent_rev": "2355cd0f244b36a930c930f6a6000f59766dc4d8", "commit_rev":
"780ef7b430dc6976831ae4f952cf34579b101f70"}

[commit-bot: I haz the power, 2017-04-17 21:22:34]

Description was changed from

==========
MD Settings: Network: SIM unlock: Fix focus and cancel

This CL:
* Focuses the first input field for all sim dialogs.
* Fixes the toggle logic when the dialog is canceled.

BUG=695409
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Network: SIM unlock: Fix focus and cancel

This CL:
* Focuses the first input field for all sim dialogs.
* Fixes the toggle logic when the dialog is canceled.

BUG=695409
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2821743002
Cr-Commit-Position: refs/heads/master@{#465021}
Committed:
https://chromium.googlesource.com/chromium/src/+/780ef7b430dc6976831ae4f952cf...
==========

[commit-bot: I haz the power, 2017-04-17 21:22:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/780ef7b430dc6976831ae4f952cf...