Make ForwardingDisplayDelegate initially sync.

Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes a synchronous call from ash to mus-ws to get the list of
display snapshots. After Shell::Init() has finished and
ForwardingDisplaySnapshot has received an OnConfigurationChanged() IPC
it resumes making calls over Mojo.

This isn't ideal because it will add significant delay to ash
initialization. It will work in the short term for mushrome though.

BUG=706589
Review-Url: https://codereview.chromium.org/2835933005
Cr-Commit-Position: refs/heads/master@{#466962}
Committed: https://chromium.googlesource.com/chromium/src/+/0a81beada89c87c32e6ac4faea3e2823985994dc

[kylechar, 2017-04-24 20:19:53]

Description was changed from

==========
Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes an asynchronous call from ash to mus-ws to get the list of
display snapshots.

This isn't ideal because it will make startp much slower.

BUG=
==========

to

==========
Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes an asynchronous call from ash to mus-ws to get the list of
display snapshots.

This isn't ideal because it will add significant delay to ash
initialization. It will work in the short term for mushrome though.

BUG=706589
==========

[kylechar, 2017-04-24 20:21:44]

Description was changed from

==========
Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes an asynchronous call from ash to mus-ws to get the list of
display snapshots.

This isn't ideal because it will add significant delay to ash
initialization. It will work in the short term for mushrome though.

BUG=706589
==========

to

==========
Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes a synchronous call from ash to mus-ws to get the list of
display snapshots. After Shell::Init() has finished and
ForwardingDisplaySnapshot has received another Mojo message it resumes
making calls over Mojo.

This isn't ideal because it will add significant delay to ash
initialization. It will work in the short term for mushrome though.

BUG=706589
==========

[kylechar, 2017-04-24 20:22:35]

Description was changed from

==========
Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes a synchronous call from ash to mus-ws to get the list of
display snapshots. After Shell::Init() has finished and
ForwardingDisplaySnapshot has received another Mojo message it resumes
making calls over Mojo.

This isn't ideal because it will add significant delay to ash
initialization. It will work in the short term for mushrome though.

BUG=706589
==========

to

==========
Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes a synchronous call from ash to mus-ws to get the list of
display snapshots. After Shell::Init() has finished and
ForwardingDisplaySnapshot has received an OnConfigurationChanged() IPC
it resumes making calls over Mojo.

This isn't ideal because it will add significant delay to ash
initialization. It will work in the short term for mushrome though.

BUG=706589
==========

[kylechar, 2017-04-24 20:47:57]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[kylechar, 2017-04-24 20:47:57]

sky: ui/* OWNERS
tsepez: mojom

[Tom Sepez, 2017-04-24 20:52:45]

lgtm

[sky, 2017-04-24 21:15:50]

LGTM

[kylechar, 2017-04-24 21:16:44]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 21:17:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 22:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 22:47:45]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-04-25 13:16:21]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-04-25 13:16:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 13:21:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493126181323470,
"parent_rev": "bf1b7c0414d63f6e3152f731e2602c8de55c73b8", "commit_rev":
"0a81beada89c87c32e6ac4faea3e2823985994dc"}

[commit-bot: I haz the power, 2017-04-25 13:21:48]

Description was changed from

==========
Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes a synchronous call from ash to mus-ws to get the list of
display snapshots. After Shell::Init() has finished and
ForwardingDisplaySnapshot has received an OnConfigurationChanged() IPC
it resumes making calls over Mojo.

This isn't ideal because it will add significant delay to ash
initialization. It will work in the short term for mushrome though.

BUG=706589
==========

to

==========
Make ForwardingDisplayDelegate initially sync.

In ash::Shell::Init() there is an assumption that NativeDisplayDelegate
is synchronous. This is accomplished through a couple of hacks with
Ozone DRM to load the current DisplaySnapshots in the browser process.

We need to do something similar for mushrome. This is a quick workaround
that makes a synchronous call from ash to mus-ws to get the list of
display snapshots. After Shell::Init() has finished and
ForwardingDisplaySnapshot has received an OnConfigurationChanged() IPC
it resumes making calls over Mojo.

This isn't ideal because it will add significant delay to ash
initialization. It will work in the short term for mushrome though.

BUG=706589

Review-Url: https://codereview.chromium.org/2835933005
Cr-Commit-Position: refs/heads/master@{#466962}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a81beada89c87c32e6ac4faea3e...
==========

[commit-bot: I haz the power, 2017-04-25 13:21:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a81beada89c87c32e6ac4faea3e...