Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: mojo/public/cpp/bindings/sync_call_restrictions.h

Issue 2835933005: Make ForwardingDisplayDelegate initially sync. (Closed)
Patch Set: Add comment explaining sync usage. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/ui/display/screen_manager_forwarding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/sync_call_restrictions.h
diff --git a/mojo/public/cpp/bindings/sync_call_restrictions.h b/mojo/public/cpp/bindings/sync_call_restrictions.h
index 55290427845ab7f2817189fe42c9ab4dab1651c6..f83f3f0f5ee0fb18fb6e88817faca396bc560039 100644
--- a/mojo/public/cpp/bindings/sync_call_restrictions.h
+++ b/mojo/public/cpp/bindings/sync_call_restrictions.h
@@ -15,6 +15,10 @@
#define ENABLE_SYNC_CALL_RESTRICTIONS 0
#endif
+namespace display {
+class ForwardingDisplayDelegate;
+}
+
namespace leveldb {
class LevelDBMojoProxy;
}
@@ -72,6 +76,10 @@ class MOJO_CPP_BINDINGS_EXPORT SyncCallRestrictions {
// implementation which weren't caught by sync call restrictions. Our blocking
// calls to mus, however, are.
friend class views::ClipboardMus;
+ // In ash::Shell::Init() it assumes that NativeDisplayDelegate will be
+ // synchronous at first. In mushrome ForwardingDisplayDelegate uses a
+ // synchronous call to get the display snapshots as a workaround.
+ friend class display::ForwardingDisplayDelegate;
// END USAGE THAT NEEDS TO BE FIXED.
#if ENABLE_SYNC_CALL_RESTRICTIONS
« no previous file with comments | « no previous file | services/ui/display/screen_manager_forwarding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698