|
Revert of [DevTools] Consolidate overlay-related functionality in Overlay domain (patchset #7 id:120001 of https://codereview.chromium.org/2819183002/ )
Reason for revert:
This seems to be breaking the devtools closure compiler, i.e., closure is reporting an error:
https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/55326
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests%2F55326%2F%2B%2Frecipes%2Fsteps%2Fdevtools_closure_compile%2F0%2Fstdout
Command: /usr/bin/python ../../testing/scripts/run_devtools_check.py ../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py --isolated-script-test-output=/b/s/w/ioH2ERuI/output.json --isolated-script-test-chartjson-output=/b/s/w/ioH2ERuI/chartjson-output.json
Java executable: /usr/bin/java
Compiling frontend...
Compiling devtools_compatibility.js...
Verifying JSDoc comments...
devtools_compatibility.js compilation output:
0 error(s), 0 warning(s), 95.2% typed
devtools frontend compilation output:
/b/s/w/itFkGMoq/tmp_x1qK7/front_end/emulation/DeviceModeModel.js:640: WARNING - Property renderingAgent never defined on SDK.Target
this._target.renderingAgent().setShowViewportSizeOnResize(false);
^^^^^^^^^^^^^^
0 error(s), 1 warning(s), 94.3% typed
ERRORS DETECTED
Running ['/usr/bin/python', '../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py'] in None (env: None)
Command ['/usr/bin/python', '../../third_party/WebKit/Source/devtools/scripts/compile_frontend.py'] returned exit code 1
Original issue's description:
> [DevTools] Consolidate overlay-related functionality in Overlay domain
>
> This turns InspectorOverlay into InspectorOverlayAgent with respective
> lifetime and domain:
> - rendering domain merges into overlay;
> - Page.configureOverlay moves to overlay;
> - highlighting and inspect mode move from DOM to overlay.
>
> BUG=none
> TBR=skyostil@chromium.org
>
> Review-Url: https://codereview.chromium.org/2819183002
> Cr-Original-Original-Commit-Position: refs/heads/master@{#465422}
> Committed: https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae58cff1c787bec
> Review-Url: https://codereview.chromium.org/2819183002
> Cr-Original-Commit-Position: refs/heads/master@{#465812}
> Committed: https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a689648621fa29f14
> Review-Url: https://codereview.chromium.org/2819183002
> Cr-Commit-Position: refs/heads/master@{#466489}
> Committed: https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4122f4d50246a
TBR=pfeldman@chromium.org,skyostil@chromium.org,dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none
Review-Url: https://codereview.chromium.org/2835843002
Cr-Commit-Position: refs/heads/master@{#466557}
Committed: https://chromium.googlesource.com/chromium/src/+/c1bc835e0ead2a64955b96ebde29ea191280f99e
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+2185 lines, -2128 lines) |
Patch |
 |
M |
content/browser/devtools/protocol/schema_handler.cc
|
View
|
|
1 chunk |
+8 lines, -31 lines |
0 comments
|
Download
|
 |
M |
headless/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
headless/lib/browser/headless_devtools_client_impl.h
|
View
|
|
3 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
headless/lib/browser/headless_devtools_client_impl.cc
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
headless/public/headless_devtools_client.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled.html
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector/agents-enable-disable-expected.txt
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector/elements/inspect-mode-after-profiling.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector/elements/inspect-mode-shadow-text.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector/elements/inspect-pointer-events-none.html
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector/elements/inspect-pseudo-element.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector/layers/no-overlay-layers.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/BUILD.gn
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
|
View
|
|
9 chunks |
+68 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
|
View
|
|
9 chunks |
+263 lines, -27 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/InspectorOverlayHost.h
|
View
|
|
1 chunk |
+9 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/InspectorOverlayHost.cpp
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
|
View
|
|
4 chunks |
+22 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/browser_protocol.json
|
View
|
|
7 chunks |
+112 lines, -137 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/ElementsBreadcrumbs.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js
|
View
|
|
3 chunks |
+19 lines, -19 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js
|
View
|
|
4 chunks |
+10 lines, -12 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/layer_viewer/LayerViewHost.js
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/main/Main.js
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
|
View
|
|
1 chunk |
+43 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
|
View
|
|
4 chunks |
+48 lines, -21 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/main/module.json
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
|
View
|
|
7 chunks |
+15 lines, -15 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
|
View
|
|
11 chunks |
+247 lines, -7 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/devtools/front_end/sdk/OverlayModel.js
|
View
|
|
1 chunk |
+0 lines, -320 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sdk/module.json
|
View
|
|
2 chunks |
+0 lines, -29 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/BUILD.gn
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/web/InspectorOverlay.h
|
View
|
|
1 chunk |
+171 lines, -0 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/web/InspectorOverlay.cpp
|
View
|
|
1 chunk |
+827 lines, -0 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/web/InspectorOverlayAgent.h
|
View
|
|
1 chunk |
+0 lines, -222 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/Source/web/InspectorOverlayAgent.cpp
|
View
|
|
1 chunk |
+0 lines, -1162 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/web/InspectorRenderingAgent.h
|
View
|
|
1 chunk |
+48 lines, -0 lines |
0 comments
|
Download
|
 |
A |
third_party/WebKit/Source/web/InspectorRenderingAgent.cpp
|
View
|
|
1 chunk |
+126 lines, -0 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
|
View
|
|
5 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
|
View
|
|
16 chunks |
+48 lines, -27 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebFrameWidgetImpl.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebViewImpl.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/web/WebViewImpl.cpp
|
View
|
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
Total messages: 6 (3 generated)
|