Refactor the UpdateEngine and its actions in the component updater.

Refactor the UpdateEngine and its actions in the component updater.

R=waffles@chromium.org
BUG=687231
Review-Url: https://codereview.chromium.org/2835803002
Cr-Commit-Position: refs/heads/master@{#467535}
Committed: https://chromium.googlesource.com/chromium/src/+/30474f06441fe7325ce99815f6337e2f9d425b7e

[Sorin Jianu, 2017-04-22 03:05:19]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 03:05:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 04:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 04:13:57]

Dry run: This issue passed the CQ dry run.

[Sorin Jianu, 2017-04-24 16:58:10]

PTAL!

[waffles, 2017-04-24 18:57:22]

lgtm

https://codereview.chromium.org/2835803002/diff/1/components/update_client/co...
File components/update_client/component.h (right):

https://codereview.chromium.org/2835803002/diff/1/components/update_client/co...
components/update_client/component.h:38: // only exists if it is associated with
an UpdateContext.
exists → exist

or "Each |Component| is associated with an UpdateContext."

https://codereview.chromium.org/2835803002/diff/1/components/update_client/co...
components/update_client/component.h:152: State(Component* component,
ComponentState state);
Should this be protected?

https://codereview.chromium.org/2835803002/diff/1/components/update_client/up...
File components/update_client/update_client_internal.h (right):

https://codereview.chromium.org/2835803002/diff/1/components/update_client/up...
components/update_client/update_client_internal.h:65: // True is Stop method has
been called.
is→if

[Sorin Jianu, 2017-04-24 23:26:45]

thank you!

https://codereview.chromium.org/2835803002/diff/1/components/update_client/co...
File components/update_client/component.h (right):

https://codereview.chromium.org/2835803002/diff/1/components/update_client/co...
components/update_client/component.h:38: // only exists if it is associated with
an UpdateContext.
On 2017/04/24 18:57:22, waffles wrote:
> exists → exist
> 
> or "Each |Component| is associated with an UpdateContext."

Done.

https://codereview.chromium.org/2835803002/diff/1/components/update_client/co...
components/update_client/component.h:152: State(Component* component,
ComponentState state);
On 2017/04/24 18:57:22, waffles wrote:
> Should this be protected?

It seems ok to be public. The inner base class is private, and it is abstract.
The outer class or its friends can't instantiate the inner base class anyway.

https://codereview.chromium.org/2835803002/diff/1/components/update_client/up...
File components/update_client/update_client_internal.h (right):

https://codereview.chromium.org/2835803002/diff/1/components/update_client/up...
components/update_client/update_client_internal.h:65: // True is Stop method has
been called.
On 2017/04/24 18:57:22, waffles wrote:
> is→if

Done.

[Sorin Jianu, 2017-04-24 23:28:34]

sorin@chromium.org changed reviewers:
+ tommycli@chromium.org

[Sorin Jianu, 2017-04-24 23:28:35]

Tommy, could you please take a look at changes under chrome/browser/ui/webui/

I need an owner's review please.

Thank you!

[tommycli, 2017-04-24 23:49:49]

On 2017/04/24 23:28:35, Sorin Jianu wrote:
> Tommy, could you please take a look at changes under chrome/browser/ui/webui/
> 
> I need an owner's review please.
> 
> Thank you!

webui changes look harmless. thanks. lgtm

[Sorin Jianu, 2017-04-26 22:12:40]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 22:13:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2017-04-26 23:21:04]

The CQ bit was unchecked by sorin@chromium.org

[Sorin Jianu, 2017-04-26 23:21:23]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2017-04-26 23:21:24]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/2835803002/#ps20001
(title: "feedback up to #6")

[commit-bot: I haz the power, 2017-04-26 23:22:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 00:45:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493248883774010,
"parent_rev": "962039b4911c544f388dd71171dd43eea6c4c755", "commit_rev":
"ce0b3c752c971568c0de8c00c9a26eeb2a16438d"}

[commit-bot: I haz the power, 2017-04-27 00:46:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493248883774010,
"parent_rev": "f3ab530a8e4e050ddeccf5df07fb25fc0c2629fa", "commit_rev":
"ae01569bb2e72c2ef81b55452f184cffd30f178b"}

[commit-bot: I haz the power, 2017-04-27 00:47:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493248883774010,
"parent_rev": "190ee07cecf53e3795197cc195b844f7cc15a9ea", "commit_rev":
"30474f06441fe7325ce99815f6337e2f9d425b7e"}

[commit-bot: I haz the power, 2017-04-27 00:49:13]

Description was changed from

==========
Refactor the UpdateEngine and its actions in the component updater.

R=waffles@chromium.org
BUG=687231
==========

to

==========
Refactor the UpdateEngine and its actions in the component updater.

R=waffles@chromium.org
BUG=687231

Review-Url: https://codereview.chromium.org/2835803002
Cr-Commit-Position: refs/heads/master@{#467535}
Committed:
https://chromium.googlesource.com/chromium/src/+/30474f06441fe7325ce99815f633...
==========

[commit-bot: I haz the power, 2017-04-27 00:49:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/30474f06441fe7325ce99815f633...