Refactor the UpdateEngine and its actions in the component updater.

components/update_client/update_client_internal.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UPDATE_CLIENT_UPDATE_CLIENT_INTERNAL_H_
 #define COMPONENTS_UPDATE_CLIENT_UPDATE_CLIENT_INTERNAL_H_
 
 #include <memory>
 #include <queue>
 #include <set>
@@ skipping 44 matching lines @@
  private:
   ~UpdateClientImpl() override;
 
   void RunTask(std::unique_ptr<Task> task);
   void OnTaskComplete(const Callback& callback, Task* task, Error error);
 
   void NotifyObservers(Observer::Events event, const std::string& id);
 
   base::ThreadChecker thread_checker_;
 
   // True is Stop method has been called.

[waffles, 2017/04/24 18:57:22]

is→if

[Sorin Jianu, 2017/04/24 23:26:45]

Done.

-  bool is_stopped_;
+  bool is_stopped_ = false;
 
   scoped_refptr<Configurator> config_;
 
   // Contains the tasks that are pending. In the current implementation,
   // only update tasks (background tasks) are queued up. These tasks are
   // pending while they are in this queue. They have not been picked up yet
   // by the update engine.
   std::queue<Task*> task_queue_;
 
   // Contains all tasks in progress. These are the tasks that the update engine
   // is executing at one moment. Install tasks are run concurrently, update
   // tasks are always serialized, and update tasks are queued up if install
   // tasks are running. In addition, concurrent install tasks for the same id
   // are not allowed.
   std::set<Task*> tasks_;
 
   // TODO(sorin): try to make the ping manager an observer of the service.
   std::unique_ptr<PingManager> ping_manager_;
   std::unique_ptr<UpdateEngine> update_engine_;
 
   base::ObserverList<Observer> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(UpdateClientImpl);
 };
 
 }  // namespace update_client
 
 #endif  // COMPONENTS_UPDATE_CLIENT_UPDATE_CLIENT_INTERNAL_H_