Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2835693003:
[Mac] Build fix when using newer SDK (Closed)
Description[Mac] Build fix when using newer SDK
https://codereview.chromium.org/2828993002 broke the build
on newer SDKs.
Make sure to put assume_nonnull end with the matching begin.
BUG=710100
Review-Url: https://codereview.chromium.org/2835693003
Cr-Commit-Position: refs/heads/master@{#466443}
Committed: https://chromium.googlesource.com/chromium/src/+/86da744cba65de36f2119a03773cbd734864cc1c
Patch Set 1 #
Total comments: 2
Patch Set 2 : Move the begin instead #Messages
Total messages: 22 (13 generated)
The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
alexis.menard@intel.com changed reviewers: + rsesek@chromium.org
lgtm
Actually, this doesn't compile (see try bots). not lgtm
https://codereview.chromium.org/2835693003/diff/1/ui/base/cocoa/touch_bar_for... File ui/base/cocoa/touch_bar_forward_declarations.h (right): https://codereview.chromium.org/2835693003/diff/1/ui/base/cocoa/touch_bar_for... ui/base/cocoa/touch_bar_forward_declarations.h:115: extern "C" { This section should probably just move up to be near line 27, right?
spqchan@chromium.org changed reviewers: + spqchan@chromium.org
https://codereview.chromium.org/2835693003/diff/1/ui/base/cocoa/touch_bar_for... File ui/base/cocoa/touch_bar_forward_declarations.h (right): https://codereview.chromium.org/2835693003/diff/1/ui/base/cocoa/touch_bar_for... ui/base/cocoa/touch_bar_forward_declarations.h:96: #pragma clang assume_nonnull end Instead of putting this here, it makes more sense to move #pragma clang assume_nonnull begin to before L14
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2017/04/21 20:23:39, spqchan wrote: > https://codereview.chromium.org/2835693003/diff/1/ui/base/cocoa/touch_bar_for... > File ui/base/cocoa/touch_bar_forward_declarations.h (right): > > https://codereview.chromium.org/2835693003/diff/1/ui/base/cocoa/touch_bar_for... > ui/base/cocoa/touch_bar_forward_declarations.h:96: #pragma clang assume_nonnull > end > Instead of putting this here, it makes more sense to move > > #pragma clang assume_nonnull begin > > to before L14 uploading this. was my first option but I was not sure of myself.
The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by alexis.menard@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492808324817890,
"parent_rev": "ab3bee6aed8f51dab8a8980baae0de0223698bf1", "commit_rev":
"86da744cba65de36f2119a03773cbd734864cc1c"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Build fix when using newer SDK https://codereview.chromium.org/2828993002 broke the build on newer SDKs. Make sure to put assume_nonnull end with the matching begin. BUG=710100 ========== to ========== [Mac] Build fix when using newer SDK https://codereview.chromium.org/2828993002 broke the build on newer SDKs. Make sure to put assume_nonnull end with the matching begin. BUG=710100 Review-Url: https://codereview.chromium.org/2835693003 Cr-Commit-Position: refs/heads/master@{#466443} Committed: https://chromium.googlesource.com/chromium/src/+/86da744cba65de36f2119a03773c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/86da744cba65de36f2119a03773c... |
