Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2828993002: [Mac] Support for Touch Bar Customization (Closed)

Created:
3 years, 8 months ago by spqchan
Modified:
3 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, srahim+watch_chromium.org, danakj+watch_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Support for Touch Bar Customization Implement customization support for the default touch bar. Changed the item identifiers to reverse-DNS style format. This change landed in https://codereview.chromium.org/2814683005 but was reverted since it caused issues with the build. This CL fixes the issues. BUG=710100 Review-Url: https://codereview.chromium.org/2828993002 Cr-Commit-Position: refs/heads/master@{#466180} Committed: https://chromium.googlesource.com/chromium/src/+/b0c58f3d0a58e4149fa8aef20996de6b12580885

Patch Set 1 : Original CL #

Patch Set 2 : The Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -44 lines) Patch
M base/mac/sdk_forward_declarations.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +20 lines, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_touch_bar.mm View 8 chunks +72 lines, -34 lines 0 comments Download
M ui/base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/cocoa/touch_bar_forward_declarations.h View 1 4 chunks +13 lines, -9 lines 0 comments Download
A ui/base/cocoa/touch_bar_forward_declarations.mm View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (23 generated)
spqchan
PTAL I reverted the original CL because it was breaking some builds. I managed to ...
3 years, 8 months ago (2017-04-20 22:21:21 UTC) #19
Robert Sesek
LGTM
3 years, 8 months ago (2017-04-20 22:22:28 UTC) #20
spqchan
On 2017/04/20 22:22:28, Robert Sesek wrote: > LGTM thanks!
3 years, 8 months ago (2017-04-20 22:23:12 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828993002/100001
3 years, 8 months ago (2017-04-20 22:29:38 UTC) #25
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 23:14:13 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/b0c58f3d0a58e4149fa8aef20996...

Powered by Google App Engine
This is Rietveld 408576698