Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2835673002: Disable raf alignment when the compositor doesn't generate begin frames. (Closed)

Created:
3 years, 8 months ago by dtapuska
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable raf alignment when the compositor doesn't generate begin frames. Background pages don't get raf signals so we can't align the mouse events to a signal that never comes. BUG=703344 Review-Url: https://codereview.chromium.org/2835673002 Cr-Commit-Position: refs/heads/master@{#466638} Committed: https://chromium.googlesource.com/chromium/src/+/b08611fc4ffe28a782fad5fcbf6a881b01c154be

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M content/renderer/input/input_event_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
dtapuska
3 years, 8 months ago (2017-04-21 17:24:09 UTC) #2
dtapuska
switching for aelias@ to review seems tdresser is OOO
3 years, 8 months ago (2017-04-21 21:21:12 UTC) #8
aelias_OOO_until_Jul13
lgtm https://codereview.chromium.org/2835673002/diff/1/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/2835673002/diff/1/content/renderer/render_widget.cc#newcode1315 content/renderer/render_widget.cc:1315: bool should_geneate_frame_sink = typo: "generate"
3 years, 8 months ago (2017-04-21 21:45:28 UTC) #9
dtapuska
https://codereview.chromium.org/2835673002/diff/1/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/2835673002/diff/1/content/renderer/render_widget.cc#newcode1315 content/renderer/render_widget.cc:1315: bool should_geneate_frame_sink = On 2017/04/21 21:45:28, aelias wrote: > ...
3 years, 8 months ago (2017-04-24 13:44:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835673002/20001
3 years, 8 months ago (2017-04-24 13:44:41 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 16:10:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b08611fc4ffe28a782fad5fcbf6a...

Powered by Google App Engine
This is Rietveld 408576698