Get rid of the in_flight_event.

Get rid of the in_flight_event.

It was possible that a nested message loop occurs in the processing
event actually gets destroyed by running an event inside the nested loop.

Put the object on the stack instead since we no longer have the virtual
callback that we required this member for. Also this might actually be
the cause to further hung renderers because under the old code the missing
acks would silently get dropped. After https://codereview.chromium.org/2813683002
this caused a null-deref.

BUG=714444
Review-Url: https://codereview.chromium.org/2835193002
Cr-Commit-Position: refs/heads/master@{#466645}
Committed: https://chromium.googlesource.com/chromium/src/+/a721e02d8c476695c09870f913329618232ea50f

[dtapuska, 2017-04-24 14:17:38]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[dtapuska, 2017-04-24 14:17:43]

Description was changed from

==========
Get rid of the in_flight_event.

It was possible that a nested message loop occurs in the processing
event actually gets destroyed by running an event inside the nested loop.

Put the object on the stack instead since we no longer have the virtual
callback that we required this member for. Also this might actually be
the cause to further hung renderers because under the old code the missing
acks would silently get dropped. After
https://codereview.chromium.org/2813683002
this caused a null-deref.

BUG=714444
==========

to

==========
Get rid of the in_flight_event.

It was possible that a nested message loop occurs in the processing
event actually gets destroyed by running an event inside the nested loop.

Put the object on the stack instead since we no longer have the virtual
callback that we required this member for. Also this might actually be
the cause to further hung renderers because under the old code the missing
acks would silently get dropped. After
https://codereview.chromium.org/2813683002
this caused a null-deref.

BUG=714444
==========

[dtapuska, 2017-04-24 14:17:43]

dtapuska@chromium.org changed reviewers:
+ mustaq@chromium.org

[commit-bot: I haz the power, 2017-04-24 14:18:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2017-04-24 14:29:55]

lgtm

[commit-bot: I haz the power, 2017-04-24 15:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 15:39:45]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2017-04-24 16:17:06]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2017-04-24 16:17:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 16:24:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493050626694850, "parent_rev":
"efefc5f07998074ebaa5020fdfeb9639d0c1ca21", "commit_rev":
"a721e02d8c476695c09870f913329618232ea50f"}

[commit-bot: I haz the power, 2017-04-24 16:24:33]

Description was changed from

==========
Get rid of the in_flight_event.

It was possible that a nested message loop occurs in the processing
event actually gets destroyed by running an event inside the nested loop.

Put the object on the stack instead since we no longer have the virtual
callback that we required this member for. Also this might actually be
the cause to further hung renderers because under the old code the missing
acks would silently get dropped. After
https://codereview.chromium.org/2813683002
this caused a null-deref.

BUG=714444
==========

to

==========
Get rid of the in_flight_event.

It was possible that a nested message loop occurs in the processing
event actually gets destroyed by running an event inside the nested loop.

Put the object on the stack instead since we no longer have the virtual
callback that we required this member for. Also this might actually be
the cause to further hung renderers because under the old code the missing
acks would silently get dropped. After
https://codereview.chromium.org/2813683002
this caused a null-deref.

BUG=714444

Review-Url: https://codereview.chromium.org/2835193002
Cr-Commit-Position: refs/heads/master@{#466645}
Committed:
https://chromium.googlesource.com/chromium/src/+/a721e02d8c476695c09870f91332...
==========

[commit-bot: I haz the power, 2017-04-24 16:24:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a721e02d8c476695c09870f91332...