Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(246)

Issue 2835633002: Add more checks to diagnose MediaQuerySet issue (Closed)

Created:
12 months ago by keishi
Modified:
12 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, Mads Ager (chromium), blink-reviews-style_chromium.org, sof, eae+blinkwatch, haraken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, kouhei+heap_chromium.org, oilpan-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more checks to diagnose MediaQuerySet issue Adding more CHECKs to diagnose the MediaQuerySet related crashers. BUG=699269 Review-Url: https://codereview.chromium.org/2835633002 Cr-Commit-Position: refs/heads/master@{#466556} Committed: https://chromium.googlesource.com/chromium/src/+/8b1af150d41e5cf5264929e3c7bd5c7f55f05390

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/MediaList.cpp View 1 5 chunks +12 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
keishi
PTAL
12 months ago (2017-04-21 10:21:53 UTC) #5
sof
lgtm
12 months ago (2017-04-21 10:33:50 UTC) #9
haraken
LGTM https://codereview.chromium.org/2835633002/diff/20001/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp File third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp (right): https://codereview.chromium.org/2835633002/diff/20001/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp#newcode53 third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp:53: CHECK(HeapObjectHeader::FromPayload(this)->IsValid()); Add a TODO to remove the checks ...
12 months ago (2017-04-21 10:51:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835633002/40001
12 months ago (2017-04-23 03:51:53 UTC) #15
commit-bot: I haz the power
12 months ago (2017-04-23 05:30:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8b1af150d41e5cf5264929e3c7bd...

Powered by Google App Engine
This is Rietveld 408576698