Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp

Issue 2835633002: Add more checks to diagnose MediaQuerySet issue (Closed)
Patch Set: added comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp
diff --git a/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp b/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp
index bb422e0ca97c250efaa68788420776827ce1b193..33c9cc9ca2d4f51517938796f1aef1f598847d1a 100644
--- a/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp
+++ b/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp
@@ -50,7 +50,12 @@ void DocumentStyleSheetCollection::CollectStyleSheetsFromCandidates(
DocumentStyleSheetCollector& collector) {
DocumentOrderedList::MutationForbiddenScope mutation_forbidden_(
&style_sheet_candidate_nodes_);
+ // TODO(keishi) Check added for crbug.com/699269 diagnosis. Remove once done.
+ CHECK(HeapObjectHeader::FromPayload(this)->IsValid());
+ CHECK(ThreadState::Current()->IsOnThreadHeap(this));
for (Node* n : style_sheet_candidate_nodes_) {
+ CHECK(HeapObjectHeader::FromPayload(n)->IsValid());
+ CHECK(ThreadState::Current()->IsOnThreadHeap(n));
StyleSheetCandidate candidate(*n);
DCHECK(!candidate.IsXSL());
« no previous file with comments | « third_party/WebKit/Source/core/css/MediaList.cpp ('k') | third_party/WebKit/Source/platform/heap/HeapPage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698