Add ErrorPageTestCase to external url test suite.

Add ErrorPageTestCase to external url test suite.

BUG=694662
Review-Url: https://codereview.chromium.org/2835563002
Cr-Commit-Position: refs/heads/master@{#466421}
Committed: https://chromium.googlesource.com/chromium/src/+/24efb2134c61d1a276c082aca21e7b681166396c

[huangml1, 2017-04-20 22:17:26]

huangml@chromium.org changed reviewers:
+ eugenebut@chromium.org, sdefresne@chromium.org

[Eugene But (OOO till 7-30), 2017-04-20 22:50:37]

https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD.gn
File ios/chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD...
ios/chrome/browser/ui/BUILD.gn:505: "error_page_egtest.mm",
External URL tests have external_url_ prefix and live in
ios_internal/chrome/test/external_url directory. Is there a reason why error
page test should be different?

[huangml1, 2017-04-20 22:56:19]

On 2017/04/20 22:50:37, Eugene But wrote:
>
https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD.gn
> File ios/chrome/browser/ui/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD...
> ios/chrome/browser/ui/BUILD.gn:505: "error_page_egtest.mm",
> External URL tests have external_url_ prefix and live in
> ios_internal/chrome/test/external_url directory. Is there a reason why error
> page test should be different?

No specific reason.  I moved these tests here since this external url suite
already exists upstream.  I guess we want to keep them run upstream?

[huangml1, 2017-04-20 23:02:35]

On 2017/04/20 22:56:19, huangml1 wrote:
> On 2017/04/20 22:50:37, Eugene But wrote:
> >
>
https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD.gn
> > File ios/chrome/browser/ui/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD...
> > ios/chrome/browser/ui/BUILD.gn:505: "error_page_egtest.mm",
> > External URL tests have external_url_ prefix and live in
> > ios_internal/chrome/test/external_url directory. Is there a reason why error
> > page test should be different?
> 
> No specific reason.  I moved these tests here since this external url suite
> already exists upstream.  I guess we want to keep them run upstream?

In fact,  only the sign in tests depend on internal files.  Why don't we move
all other tests upstream?

[Eugene But (OOO till 7-30), 2017-04-20 23:34:55]

On 2017/04/20 23:02:35, huangml1 wrote:
> On 2017/04/20 22:56:19, huangml1 wrote:
> > On 2017/04/20 22:50:37, Eugene But wrote:
> > >
> >
>
https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD.gn
> > > File ios/chrome/browser/ui/BUILD.gn (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD...
> > > ios/chrome/browser/ui/BUILD.gn:505: "error_page_egtest.mm",
> > > External URL tests have external_url_ prefix and live in
> > > ios_internal/chrome/test/external_url directory. Is there a reason why
error
> > > page test should be different?
> > 
> > No specific reason.  I moved these tests here since this external url suite
> > already exists upstream.  I guess we want to keep them run upstream?
> 
> In fact,  only the sign in tests depend on internal files.  Why don't we move
> all other tests upstream?

[huangml1, 2017-04-21 00:03:01]

huangml@chromium.org changed reviewers:
+ baxley@chromium.org, rohitrao@chromium.org

[huangml1, 2017-04-21 00:03:02]

We might want to discuss if it's good to put these tests upstream.  They are
hitting a real URL that does not exist (http://mock/bad).

https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD.gn
File ios/chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD...
ios/chrome/browser/ui/BUILD.gn:505: "error_page_egtest.mm",
On 2017/04/20 22:50:36, Eugene But wrote:
> External URL tests have external_url_ prefix and live in
> ios_internal/chrome/test/external_url directory. Is there a reason why error
> page test should be different?

No specific reason.  I moved these tests here since this external url suite
already exists upstream.  I guess we want to keep them run upstream?

[Eugene But (OOO till 7-30), 2017-04-21 00:17:27]

lgtm with comment.

For all practical reasons this is external url test. It's not great that it
relies on DNS resolution failure but it is what it is.

https://codereview.chromium.org/2835563002/diff/20001/ios/chrome/browser/ui/B...
File ios/chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2835563002/diff/20001/ios/chrome/browser/ui/B...
ios/chrome/browser/ui/BUILD.gn:505: "error_page_egtest.mm",
s/error_page_egtest/external_url_error_page_egtest

[sdefresne, 2017-04-21 13:20:43]

lgtm

[huangml1, 2017-04-21 18:55:27]

The CQ bit was checked by huangml@chromium.org

[huangml1, 2017-04-21 18:55:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2835563002/#ps40001
(title: "Filename")

[commit-bot: I haz the power, 2017-04-21 18:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 19:53:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492800927295940,
"parent_rev": "bb6bd03c3f93f7225341020eb9d94dfda706d9e7", "commit_rev":
"24efb2134c61d1a276c082aca21e7b681166396c"}

[commit-bot: I haz the power, 2017-04-21 19:53:26]

Description was changed from

==========
Add ErrorPageTestCase to external url test suite.

BUG=694662
==========

to

==========
Add ErrorPageTestCase to external url test suite.

BUG=694662

Review-Url: https://codereview.chromium.org/2835563002
Cr-Commit-Position: refs/heads/master@{#466421}
Committed:
https://chromium.googlesource.com/chromium/src/+/24efb2134c61d1a276c082aca21e...
==========

[commit-bot: I haz the power, 2017-04-21 19:53:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/24efb2134c61d1a276c082aca21e...