Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 2835563002: Add ErrorPageTestCase to external url test suite. (Closed)

Created:
3 years, 8 months ago by huangml1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ErrorPageTestCase to external url test suite. BUG=694662 Review-Url: https://codereview.chromium.org/2835563002 Cr-Commit-Position: refs/heads/master@{#466421} Committed: https://chromium.googlesource.com/chromium/src/+/24efb2134c61d1a276c082aca21e7b681166396c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename #

Total comments: 1

Patch Set 3 : Filename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -189 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 2 1 chunk +19 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/error_page_egtest.mm View 1 2 1 chunk +0 lines, -185 lines 0 comments Download
A + ios/chrome/browser/ui/external_url_error_page_egtest.mm View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/test/earl_grey/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
huangml1
3 years, 8 months ago (2017-04-20 22:17:27 UTC) #2
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD.gn File ios/chrome/browser/ui/BUILD.gn (right): https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD.gn#newcode505 ios/chrome/browser/ui/BUILD.gn:505: "error_page_egtest.mm", External URL tests have external_url_ prefix and live ...
3 years, 8 months ago (2017-04-20 22:50:37 UTC) #3
huangml1
On 2017/04/20 22:50:37, Eugene But wrote: > https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD.gn > File ios/chrome/browser/ui/BUILD.gn (right): > > https://codereview.chromium.org/2835563002/diff/1/ios/chrome/browser/ui/BUILD.gn#newcode505 ...
3 years, 8 months ago (2017-04-20 22:56:19 UTC) #4
huangml1
On 2017/04/20 22:56:19, huangml1 wrote: > On 2017/04/20 22:50:37, Eugene But wrote: > > > ...
3 years, 8 months ago (2017-04-20 23:02:35 UTC) #5
Eugene But (OOO till 7-30)
On 2017/04/20 23:02:35, huangml1 wrote: > On 2017/04/20 22:56:19, huangml1 wrote: > > On 2017/04/20 ...
3 years, 8 months ago (2017-04-20 23:34:55 UTC) #6
huangml1
We might want to discuss if it's good to put these tests upstream. They are ...
3 years, 8 months ago (2017-04-21 00:03:02 UTC) #8
Eugene But (OOO till 7-30)
lgtm with comment. For all practical reasons this is external url test. It's not great ...
3 years, 8 months ago (2017-04-21 00:17:27 UTC) #9
sdefresne
lgtm
3 years, 8 months ago (2017-04-21 13:20:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835563002/40001
3 years, 8 months ago (2017-04-21 18:55:50 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 19:53:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/24efb2134c61d1a276c082aca21e...

Powered by Google App Engine
This is Rietveld 408576698