Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: ios/chrome/browser/ui/BUILD.gn

Issue 2835563002: Add ErrorPageTestCase to external url test suite. (Closed)
Patch Set: Filename Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/error_page_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/BUILD.gn
diff --git a/ios/chrome/browser/ui/BUILD.gn b/ios/chrome/browser/ui/BUILD.gn
index 34024c6a2452d58409a20024749248ec14724f40..441c84425d8a3d8c6e8488ab8615bb2ff2fc482f 100644
--- a/ios/chrome/browser/ui/BUILD.gn
+++ b/ios/chrome/browser/ui/BUILD.gn
@@ -496,12 +496,30 @@ bundle_data("resources_unit_tests") {
]
}
+# These tests use external URLs and hit network. They will fail if the network
+# is unavailable. Reference to crbug.com/694662.
+source_set("external_url_eg_tests") {
+ configs += [ "//build/config/compiler:enable_arc" ]
+ testonly = true
+ sources = [
+ "external_url_error_page_egtest.mm",
+ ]
+ deps = [
+ "//components/strings",
+ "//ios/chrome/test/app:test_support",
+ "//ios/chrome/test/earl_grey:test_support",
+ "//ios/web:earl_grey_test_support",
+ "//ios/web:test_support",
+ "//ui/base",
+ ]
+ libs = [ "XCTest.framework" ]
+}
+
source_set("eg_tests") {
configs += [ "//build/config/compiler:enable_arc" ]
testonly = true
sources = [
"browser_view_controller_egtest.mm",
- "error_page_egtest.mm",
"fullscreen_egtest.mm",
"keyboard_commands_egtest.mm",
]
« no previous file with comments | « no previous file | ios/chrome/browser/ui/error_page_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698