Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2835413004: Image Capture: catch NoSuchFieldError if reading CONTROL_{AE,AWB}_LOCK_AVAILABLE where not available (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Image Capture: catch NoSuchFieldError if reading CONTROL_{AE,AWB}_LOCK_AVAILABLE where not available This CL adds a catch-ignore NoSuchFieldError exception, this is thrown reading the said fields in APIs >= 21 but < 23, where the constants identifying the fields are not defined. This is totally my bad: I thought unknown constants would return false, but instead they throw an Exception, which causes a crash, caught by fbeaufort@ :sweaty smile emoji: BUG=713417 Review-Url: https://codereview.chromium.org/2844503002 Cr-Commit-Position: refs/heads/master@{#467127} (cherry picked from commit 1a40ccb58c0b71b3cc5f1a0416d556982268fb6c) Review-Url: https://codereview.chromium.org/2835413004 . Cr-Commit-Position: refs/branch-heads/3071@{#208} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/97d03db2f6dfed77629857607ac3634a86de9f34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mcasas
3 years, 8 months ago (2017-04-25 22:36:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
97d03db2f6dfed77629857607ac3634a86de9f34.

Powered by Google App Engine
This is Rietveld 408576698