Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2844503002: Image Capture: catch NoSuchFieldError if reading CONTROL_{AE,AWB}_LOCK_AVAILABLE where not available (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, agrieve+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: catch NoSuchFieldError if reading CONTROL_{AE,AWB}_LOCK_AVAILABLE where not available This CL adds a catch-ignore NoSuchFieldError exception, this is thrown reading the said fields in APIs >= 21 but < 23, where the constants identifying the fields are not defined. This is totally my bad: I thought unknown constants would return false, but instead they throw an Exception, which causes a crash, caught by fbeaufort@ :sweaty smile emoji: BUG=713417 Review-Url: https://codereview.chromium.org/2844503002 Cr-Commit-Position: refs/heads/master@{#467127} Committed: https://chromium.googlesource.com/chromium/src/+/1a40ccb58c0b71b3cc5f1a0416d556982268fb6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mcasas
reillyg@ tiny follow-up CL, PTAL
3 years, 8 months ago (2017-04-25 18:25:40 UTC) #4
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-04-25 19:57:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844503002/1
3 years, 8 months ago (2017-04-25 20:15:03 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 21:48:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a40ccb58c0b71b3cc5f1a0416d5...

Powered by Google App Engine
This is Rietveld 408576698