Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2835413003: [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:unit_tests to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2835413003 Cr-Commit-Position: refs/heads/master@{#467703} Committed: https://chromium.googlesource.com/chromium/src/+/13d8b0a4a7b94f2da075aeeecf2f7231115a9e07

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M ios/chrome/browser/ui/toolbar/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm View 1 2 chunks +8 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios_unittest.mm View 1 3 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller_unittest.mm View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-25 20:06:00 UTC) #6
sdefresne
lgtm with comments https://codereview.chromium.org/2835413003/diff/1/ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm File ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm (right): https://codereview.chromium.org/2835413003/diff/1/ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm#newcode36 ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm:36: void SetUp() override { Please add ...
3 years, 7 months ago (2017-04-27 13:40:58 UTC) #7
gambard
Thanks! https://codereview.chromium.org/2835413003/diff/1/ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm File ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm (right): https://codereview.chromium.org/2835413003/diff/1/ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm#newcode36 ios/chrome/browser/ui/toolbar/toolbar_controller_unittest.mm:36: void SetUp() override { On 2017/04/27 13:40:58, sdefresne ...
3 years, 7 months ago (2017-04-27 14:58:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835413003/20001
3 years, 7 months ago (2017-04-27 14:58:47 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 16:21:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/13d8b0a4a7b94f2da075aeeecf2f...

Powered by Google App Engine
This is Rietveld 408576698