Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios_unittest.mm

Issue 2835413003: [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:unit_tests to ARC. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Foundation/Foundation.h> 5 #import <Foundation/Foundation.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/mac/scoped_nsobject.h"
10 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
11 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
12 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
13 #include "components/bookmarks/browser/bookmark_model.h" 12 #include "components/bookmarks/browser/bookmark_model.h"
14 #include "components/bookmarks/test/bookmark_test_helpers.h" 13 #include "components/bookmarks/test/bookmark_test_helpers.h"
15 #include "components/toolbar/test_toolbar_model.h" 14 #include "components/toolbar/test_toolbar_model.h"
16 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h" 15 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"
17 #include "ios/chrome/browser/browser_state/test_chrome_browser_state.h" 16 #include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
18 #include "ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.h" 17 #include "ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.h"
19 #include "ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios.h" 18 #include "ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios.h"
20 #include "ios/chrome/browser/web_state_list/fake_web_state_list_delegate.h" 19 #include "ios/chrome/browser/web_state_list/fake_web_state_list_delegate.h"
21 #include "ios/chrome/browser/web_state_list/web_state_list.h" 20 #include "ios/chrome/browser/web_state_list/web_state_list.h"
22 #import "ios/chrome/browser/xcallback_parameters.h" 21 #import "ios/chrome/browser/xcallback_parameters.h"
23 #import "ios/shared/chrome/browser/ui/toolbar/toolbar_test_util.h" 22 #import "ios/shared/chrome/browser/ui/toolbar/toolbar_test_util.h"
24 #import "ios/testing/ocmock_complex_type_helper.h" 23 #import "ios/testing/ocmock_complex_type_helper.h"
25 #import "ios/web/public/test/fakes/test_navigation_manager.h" 24 #import "ios/web/public/test/fakes/test_navigation_manager.h"
26 #import "ios/web/public/test/fakes/test_web_state.h" 25 #import "ios/web/public/test/fakes/test_web_state.h"
27 #include "ios/web/public/test/test_web_thread.h" 26 #include "ios/web/public/test/test_web_thread.h"
28 #include "ios/web/public/test/test_web_thread_bundle.h" 27 #include "ios/web/public/test/test_web_thread_bundle.h"
29 #include "testing/gtest_mac.h" 28 #include "testing/gtest_mac.h"
30 #include "testing/platform_test.h" 29 #include "testing/platform_test.h"
31 #include "third_party/ocmock/gtest_support.h" 30 #include "third_party/ocmock/gtest_support.h"
32 #include "third_party/ocmock/ocmock_extensions.h" 31 #include "third_party/ocmock/ocmock_extensions.h"
33 32
33 #if !defined(__has_feature) || !__has_feature(objc_arc)
34 #error "This file requires ARC support."
35 #endif
36
34 namespace { 37 namespace {
35 38
36 static const char kWebUrl[] = "http://www.chromium.org"; 39 static const char kWebUrl[] = "http://www.chromium.org";
37 static const char kNativeUrl[] = "chrome://version"; 40 static const char kNativeUrl[] = "chrome://version";
38 41
39 class ToolbarModelImplIOSTest : public PlatformTest { 42 class ToolbarModelImplIOSTest : public PlatformTest {
40 protected: 43 protected:
41 void SetUp() override { 44 void SetUp() override {
sdefresne 2017/04/27 13:40:58 Please add the missing call to PlatformTest::SetUp
gambard 2017/04/27 14:58:22 Done.
42 TestChromeBrowserState::Builder test_cbs_builder; 45 TestChromeBrowserState::Builder test_cbs_builder;
43 chrome_browser_state_ = test_cbs_builder.Build(); 46 chrome_browser_state_ = test_cbs_builder.Build();
44 chrome_browser_state_->CreateBookmarkModel(true); 47 chrome_browser_state_->CreateBookmarkModel(true);
45 bookmarks::test::WaitForBookmarkModelToLoad( 48 bookmarks::test::WaitForBookmarkModelToLoad(
46 ios::BookmarkModelFactory::GetForBrowserState( 49 ios::BookmarkModelFactory::GetForBrowserState(
47 chrome_browser_state_.get())); 50 chrome_browser_state_.get()));
48 51
49 // Create a WebStateList that will always return the test WebState as 52 // Create a WebStateList that will always return the test WebState as
50 // the active WebState. 53 // the active WebState.
51 web_state_list_ = base::MakeUnique<WebStateList>(&web_state_list_delegate_); 54 web_state_list_ = base::MakeUnique<WebStateList>(&web_state_list_delegate_);
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 base::UTF8ToUTF16(kWebUrl), GURL(kWebUrl)); 160 base::UTF8ToUTF16(kWebUrl), GURL(kWebUrl));
158 EXPECT_TRUE(toolbarModel_->IsCurrentTabBookmarked()); 161 EXPECT_TRUE(toolbarModel_->IsCurrentTabBookmarked());
159 162
160 // Remove the bookmark and verify the toolbar model indicates that the URL is 163 // Remove the bookmark and verify the toolbar model indicates that the URL is
161 // not bookmarked. 164 // not bookmarked.
162 bookmark_model->Remove(node); 165 bookmark_model->Remove(node);
163 EXPECT_FALSE(toolbarModel_->IsCurrentTabBookmarked()); 166 EXPECT_FALSE(toolbarModel_->IsCurrentTabBookmarked());
164 } 167 }
165 168
166 } // namespace 169 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698